SSZ tests for light client types #4938
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # beacon_node/beacon_chain/src/events.rs # beacon_node/http_api/src/lib.rs # beacon_node/http_api/src/test_utils.rs # beacon_node/http_api/tests/main.rs # beacon_node/lighthouse_network/src/rpc/codec/ssz_snappy.rs # beacon_node/lighthouse_network/src/rpc/methods.rs # beacon_node/lighthouse_network/src/service/api_types.rs # beacon_node/network/src/beacon_processor/worker/rpc_methods.rs # beacon_node/tests/test.rs # common/eth2/src/types.rs # lighthouse/src/main.rs
…tBootstrap` API to return `ForkVersionedResponse`.
- log cleanup - move http_api config mutation to `config::get_config` for consistency - fix light client API responses
jimmygchen
added
test improvement
jimmygchen
commented
Nov 21, 2023
| # LightClientFinalityUpdate | ||
| "tests/.*/.*/ssz_static/LightClientFinalityUpdate", | ||
| # LightClientHeader | ||
| "tests/.*/.*/ssz_static/LightClientHeader", |
Member
Author
There was a problem hiding this comment.
The tests are failing on CI because it hasn't accessed the capella & deneb files for light client types, might have to wait until we have the types added.
jimmygchen
added
blocked
and removed
ready-for-review
Member
Author
# Conflicts: # beacon_node/beacon_chain/src/beacon_chain.rs # consensus/types/src/light_client_bootstrap.rs # consensus/types/src/light_client_header.rs
Member
Author
|
Included in #4946 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
Addresses #4897
Proposed Changes
Add SSZ tests for Altair light client types. This doesn't cover forks after Altair, as Capella/Deneb forks are currently being implemented in #4896. We should change these tests from
altair_onlytoaltair_and_lateronce the types are implemented.PR is built on top of this branch (#3954), the diffs for this PR is in this commit: 885958e