[builder API] Make gas limit configurable, and add per-validator builderAPI usage #3342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
realbigsean
changed the title
… configurable-gas-limit � Conflicts: � lighthouse/tests/validator_client.rs � validator_client/src/cli.rs � validator_client/src/config.rs
realbigsean
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
#3295
#3357
Proposed Changes
Follows a similar pattern of management to
suggested_fee_recipient. Persistence to validator definitions file. A CLI flag that acts as a fallback for any unspecified values in the definitions file. Additionally if nothing is specified, we defaultgas_limitto30_000_000because this is the current execution layer default, and we will defaultbuilder_proposalstofalse.Blocked on #3134