[Merged by Bors] - Add lighthouse db command
#3129
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelsproul
added
enhancement
|
I'm happy to see this, great work! |
realbigsean
reviewed
Mar 31, 2022
lighthouse/src/main.rs
Outdated
| }; | ||
| } | ||
|
|
||
| if let Some(sub_matches) = matches.subcommand_matches("database_manager") { |
There was a problem hiding this comment.
Could use database_manager::CMD here
database_manager/src/lib.rs
Outdated
| App::new(CMD) | ||
| .visible_aliases(&["db"]) | ||
| .setting(clap::AppSettings::ColoredHelp) | ||
| .about("") |
| let hot_path = client_config.get_db_path(); | ||
| let cold_path = client_config.get_freezer_db_path(); | ||
|
|
||
| let mut version = CURRENT_SCHEMA_VERSION; |
There was a problem hiding this comment.
Might be useful to log out CURRENT_SCHEMA_VERSION too?
There was a problem hiding this comment.
I've added a conditional log in 6dc57a0
michaelsproul
added
ready-for-merge
|
Thanks! bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Apr 1, 2022
## Proposed Changes Add a `lighthouse db` command with three initial subcommands: - `lighthouse db version`: print the database schema version. - `lighthouse db migrate --to N`: manually upgrade (or downgrade!) the database to a different version. - `lighthouse db inspect --column C`: log the key and size in bytes of every value in a given `DBColumn`. This PR lays the groundwork for other changes, namely: - Mark's fast-deposit sync (#2915), for which I think we should implement a database downgrade (from v9 to v8). - My `tree-states` work, which already implements a downgrade (v10 to v8). - Standalone purge commands like `lighthouse db purge-dht` per #2824. ## Additional Info I updated the `strum` crate to 0.24.0, which necessitated some changes in the network code to remove calls to deprecated methods. Thanks to @winksaville for the motivation, and implementation work that I used as a source of inspiration (#2685).
|
bors r- gonna batch |
|
Canceled. |
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Apr 1, 2022
## Proposed Changes Add a `lighthouse db` command with three initial subcommands: - `lighthouse db version`: print the database schema version. - `lighthouse db migrate --to N`: manually upgrade (or downgrade!) the database to a different version. - `lighthouse db inspect --column C`: log the key and size in bytes of every value in a given `DBColumn`. This PR lays the groundwork for other changes, namely: - Mark's fast-deposit sync (#2915), for which I think we should implement a database downgrade (from v9 to v8). - My `tree-states` work, which already implements a downgrade (v10 to v8). - Standalone purge commands like `lighthouse db purge-dht` per #2824. ## Additional Info I updated the `strum` crate to 0.24.0, which necessitated some changes in the network code to remove calls to deprecated methods. Thanks to @winksaville for the motivation, and implementation work that I used as a source of inspiration (#2685).
bors
bot
changed the title
lighthouse db commandlighthouse db command
paulhauner
pushed a commit
to paulhauner/lighthouse
that referenced
this pull request
Apr 4, 2022
## Proposed Changes Add a `lighthouse db` command with three initial subcommands: - `lighthouse db version`: print the database schema version. - `lighthouse db migrate --to N`: manually upgrade (or downgrade!) the database to a different version. - `lighthouse db inspect --column C`: log the key and size in bytes of every value in a given `DBColumn`. This PR lays the groundwork for other changes, namely: - Mark's fast-deposit sync (sigp#2915), for which I think we should implement a database downgrade (from v9 to v8). - My `tree-states` work, which already implements a downgrade (v10 to v8). - Standalone purge commands like `lighthouse db purge-dht` per sigp#2824. ## Additional Info I updated the `strum` crate to 0.24.0, which necessitated some changes in the network code to remove calls to deprecated methods. Thanks to @winksaville for the motivation, and implementation work that I used as a source of inspiration (sigp#2685).
paulhauner
pushed a commit
to paulhauner/lighthouse
that referenced
this pull request
May 6, 2022
## Proposed Changes Add a `lighthouse db` command with three initial subcommands: - `lighthouse db version`: print the database schema version. - `lighthouse db migrate --to N`: manually upgrade (or downgrade!) the database to a different version. - `lighthouse db inspect --column C`: log the key and size in bytes of every value in a given `DBColumn`. This PR lays the groundwork for other changes, namely: - Mark's fast-deposit sync (sigp#2915), for which I think we should implement a database downgrade (from v9 to v8). - My `tree-states` work, which already implements a downgrade (v10 to v8). - Standalone purge commands like `lighthouse db purge-dht` per sigp#2824. ## Additional Info I updated the `strum` crate to 0.24.0, which necessitated some changes in the network code to remove calls to deprecated methods. Thanks to @winksaville for the motivation, and implementation work that I used as a source of inspiration (sigp#2685).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Add a
lighthouse dbcommand with three initial subcommands:lighthouse db version: print the database schema version.lighthouse db migrate --to N: manually upgrade (or downgrade!) the database to a different version.lighthouse db inspect --column C: log the key and size in bytes of every value in a givenDBColumn.This PR lays the groundwork for other changes, namely:
tree-stateswork, which already implements a downgrade (v10 to v8).lighthouse db purge-dhtper Addlighthouse db purge dhtsubcommand #2824.Additional Info
I updated the
strumcrate to 0.24.0, which necessitated some changes in the network code to remove calls to deprecated methods.Thanks to @winksaville for the motivation, and implementation work that I used as a source of inspiration (#2685).