[Merged by Bors] - Use windows-2019 in release CI - #3090
Closed
paulhauner wants to merge 2 commits into
Closed
Conversation
Member
Author
|
FYI #3040 switched all of the test suite actions over to |
AgeManning
approved these changes
Mar 15, 2022
Member
|
bors r+ |
|
🕐 Waiting for PR status (Github check) to be set, probably by CI. Bors will automatically try to run when all required PR statuses are set. |
bors Bot
pushed a commit
that referenced
this pull request
Mar 15, 2022
## Issue Addressed NA ## Proposed Changes Address a CI failure in the release suite. Example: https://github.com/sigp/lighthouse/actions/runs/1984266187 ## Additional Info I believe we should merge this into `unstable` and `stable`. Then, move the `v2.1.4` commit to target the commit with the updated CI. It's sad that v2.1.4 has two commits, but they're functionally equivalent for users.
paulhauner
added a commit
to paulhauner/lighthouse
that referenced
this pull request
May 6, 2022
## Issue Addressed NA ## Proposed Changes Address a CI failure in the release suite. Example: https://github.com/sigp/lighthouse/actions/runs/1984266187 ## Additional Info I believe we should merge this into `unstable` and `stable`. Then, move the `v2.1.4` commit to target the commit with the updated CI. It's sad that v2.1.4 has two commits, but they're functionally equivalent for users.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue Addressed
NA
Proposed Changes
Address a CI failure in the release suite.
Example: https://github.com/sigp/lighthouse/actions/runs/1984266187
Additional Info
I believe we should merge this into
unstableandstable. Then, move thev2.1.4commit to target the commit with the updated CI. It's sad that v2.1.4 has two commits, but they're functionally equivalent for users.