Arbitrary trait for eth2/types

[kirk-baird]

Issue Addressed

#1031

Proposed Changes

Add the Arbitrary trait for all types in eth2/types

Additional Info

• This is a work in process and currently does not build, due to conflicting types.
• It is pointing to a sigp fork but should be updated once this PR is merged.

[paulhauner]

Looks good! Only a few small things!

[kirk-baird]

The other thing I'm not sure if it's worth adding to the CI to ensure it compiles as currently the CI won't check the --features arbitrary-fuzz case for state_processing which in turn should check arbitrary for all the dependencies.

Possibly do

$ cd eth2/state_processing

$ cargo check --features arbitrary-fuzz

[paulhauner]

The other thing I'm not sure if it's worth adding to the CI to ensure it compiles as currently the CI won't check the --features arbitrary-fuzz case for state_processing which in turn should check arbitrary for all the dependencies.

I think this is a good idea. You can basically just copy-paste-modify this section and it'll run on the CI:

lighthouse/.github/workflows/test-suite.yml

Lines 77 to 83 in 36f213c

	clippy:
	runs-on: ubuntu-latest
	needs: cargo-fmt
	steps:
	- uses: actions/checkout@v1
	- name: Lint code for quality and style with Clippy
	run: make lint

[paulhauner]

Looks good! Happy to merge, but I think it's worth throwing in the CI check if you have the time. It might save some time/frustration for the fuzzing team :)

[zedt3ster]

I had to derive the Arbitrary trait on one or two more types to be able to fuzz some of the epoch state transitions. Please do not merge this yet - I'll push my changes to this PR shortly :)

[zedt3ster]

I had to derive the Arbitrary trait on one or two more types to be able to fuzz some of the epoch state transitions. Please do not merge this yet - I'll push my changes to this PR shortly :)

Done!

[paulhauner]

Happy to merge! 🎉