-
Notifications
You must be signed in to change notification settings - Fork 933
Closed
Labels
Description
Issue
Since merging #6339, we can no longer set --debug-level to crit as tracing does not support the CRIT log level and we are using a shim to make it appear that CRIT logs are actually appearing.
See this example below:
> lighthouse bn --execution-endpoint "http://localhost:8551" --debug-level crit
Unsupported log level
> lighthouse bn --execution-endpoint "http://localhost:8551" --debug-level help
error: invalid value 'help' for '--debug-level <LEVEL>'
[possible values: info, debug, trace, warn, error, crit]
Possible Solutions
- Remove
critas an option from the CLI entirely and map--debug-level critto--debug-level errorwith a deprecation notice. This is simplest solution, users can just move to using--debug-level error, which while isn't as strict ascrit, might be fine. I suspect most users aren't using--debug-level critanyway. - Intercept the CLI value, convert it to
LevelFilter::Error. We then need to find a way to restrict log output to onlyERRORs which are using thecrit!shim, I think we can slightly modify the log extractor to get this to work.
Additional Info
The same applies to --logfile-debug-level.