fix: prompt file needs to be read from stable branch#845
Merged
jking-aus merged 5 commits intosigp:stablefrom Mar 5, 2026
Merged
fix: prompt file needs to be read from stable branch#845jking-aus merged 5 commits intosigp:stablefrom
jking-aus merged 5 commits intosigp:stablefrom
Conversation
|
Review: 1 issue found
|
be82b95 to
86b6221
Compare
Member
|
Clarifying GitHub Actions behavior here (current semantics): As of December 8, 2025, A useful mental model is:
In this repo:
So the failure makes sense: checkout switched to a branch that didn’t contain Sources:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue Addressed
@claudementions fail withcat: .github/prompts/review.md: No such file or directory on PRs branched before #844, which added the shared prompt file.The workflow YAML runs from stable but reads the file from the PR's head branch, which may not have it.
Proposed Changes
Read the shared review prompt from stable instead of the checked out PR branch so it's always available regardless of when the PR was branched.
Additional Info
N/A