merge queue: embarking unstable (5bad119) and #820 together#825
Closed
mergify[bot] wants to merge 5 commits intounstablefrom
Closed
merge queue: embarking unstable (5bad119) and #820 together#825mergify[bot] wants to merge 5 commits intounstablefrom
mergify[bot] wants to merge 5 commits intounstablefrom
Conversation
…scription During fork transitions, a peer may be subscribed to the same subnet via topics from different forks (e.g., ssv.v2.42 and /ssv/mainnet/boole/42). Previously, unsubscribing from one fork's topic would clear the subnet bit entirely, even though the peer was still subscribed via the other fork's topic. Track subscriptions per fork so each fork maintains its own bitmap. Query methods aggregate across forks using bitwise union when checking subnet coverage. Closes #818 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Address review feedback: log a warning when a subnet ID exceeds the bitfield capacity instead of silently ignoring it, and add a test verifying that duplicate subscribes on the same fork+subnet don't break state.
Add peer ID to the out-of-bounds subnet warning log and replace the imperative loop in aggregate_fork_bitmaps with a functional fold.
|
Your PR title doesn't follow the Conventional Commit guidelines. Example of valid titles:
Usage:
Breaking Changes Breaking changes are noted by using an exclamation mark. For example:
Help For more information, follow the guidelines here: https://www.conventionalcommits.org/en/v1.0.0/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎉 This pull request has been checked successfully and will be merged soon. 🎉
Branch unstable (5bad119) and #820 are embarked together for merge.
This pull request has been created by Mergify to speculatively check the mergeability of #820.
You don't need to do anything. Mergify will close this pull request automatically when it is complete.
Required conditions of queue
defaultfor merge:#approved-reviews-by >= 1[🛡 GitHub repository ruleset ruleunstable and release-v*]#changes-requested-reviews-by = 0[🛡 GitHub repository ruleset ruleunstable and release-v*]check-success=test-suite-successunstable and release-v*]:check-success = license/clacheck-neutral = license/clacheck-skipped = license/claRequired conditions to stay in the queue:
#approved-reviews-by >= 1#approved-reviews-by >= 1[🛡 GitHub repository ruleset ruleunstable and release-v*]#changes-requested-reviews-by = 0[🛡 GitHub repository ruleset ruleunstable and release-v*]check-success=license/clacheck-success=target-branch-checklabel!=do-not-mergeunstable and release-v*]:check-success = license/clacheck-neutral = license/clacheck-skipped = license/cla