Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] html-sanitize config allows links in form submissions #341

Closed
signebedi opened this issue Sep 2, 2024 · 2 comments
Closed

[bug] html-sanitize config allows links in form submissions #341

signebedi opened this issue Sep 2, 2024 · 2 comments

Comments

@signebedi
Copy link
Owner

This is probably entirely because of the config we use. Specifically, we use the same html-sanitize config for form data as we use for parsing docs, privacy message, and the homepage message. These should by all accounts employ different configurations, if for no other reason because the people we expect to be submitting forms (general end users with varying degrees of scoped system access) are meaningfully different from those with access to change the docs, privacy policy, and homepage message (system admins, all of whom must, as a core assumption, have higher levels of system access). As such, we can probably just create two sanitizer objects in libreforms_fastapi.utils.docs.

Originally posted by @signebedi in #245 (comment)

@signebedi
Copy link
Owner Author

We've resolved this by essentially preventing all substantive HTML tags like and . May want to revisit at some time.

@signebedi
Copy link
Owner Author

Allow iframes in inner docs
We should allow admins to embed iframes in docs, homepages, etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant