MEDIUM: site: add attack_threshold+immediate_block #210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit brings in the latest improvements that are in go-sigsci 0.1.19 (to be released), which allows for updating the attack thresholds and/or setting the immediate block functionality. attack_threshold can be set multiple times each for the various intervals: 1, 10, 60 (in minutes). immediate_block is a bool, which will instruct the WAF to immediately block requests with attack signals. This commit depends on go-sigsci#59 as well as a new version being issued.
|
@daniel-corbett I tagged and released Could you run a couple of commands and push up the results? |
Done both - still seeing errors in the validation. Is there something else that needs to be done? |
|
@daniel-corbett the problem is likely that the build is installing We'll probably need to update the build to use the version of the provider from the current branch, rather than the registry. |
|
@shawnps - i think i fixed it. |
|
Thanks @daniel-corbett -- LGTM |
shawnps
approved these changes
Jan 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit brings in the latest improvements that are in go-sigsci 0.1.19 (to be released), which allows for updating the attack thresholds and/or setting the immediate block functionality.
attack_threshold can be set multiple times each for the various intervals: 1, 10, 60 (in minutes).
immediate_block is a bool, which will instruct the WAF to immediately block requests with attack signals.
This commit depends on signalsciences/go-sigsci#59 as well as a new version being issued.