Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: release v1.0.0 #476

Merged
merged 8 commits into from
Jun 6, 2022
Merged

chore: release v1.0.0 #476

merged 8 commits into from
Jun 6, 2022

Conversation

rauno56
Copy link
Contributor

@rauno56 rauno56 commented May 20, 2022

Description

  • Drop official support for legacy node versions 8 and 10. We know that OTel is dropping them very soon, we might as well do it now to avoid another major bump right after GA.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Internal change (a change which is not visible to the package consumers)
  • Documentation change or requires a documentation update

How Has This Been Tested?

  • Tested manually
  • Added automated tests

Checklist:

  • Unit tests have been added/updated
  • Documentation has been updated
  • Change file has been generated (npm run change:new)
  • Delete this branch (after the PR is merged)

@codecov-commenter
Copy link

codecov-commenter commented May 20, 2022

Codecov Report

Merging #476 (3cffaa1) into main (fc7b002) will increase coverage by 0.57%.
The diff coverage is 75.00%.

@@            Coverage Diff             @@
##             main     #476      +/-   ##
==========================================
+ Coverage   77.87%   78.45%   +0.57%     
==========================================
  Files          26       26              
  Lines         764      752      -12     
  Branches      170      170              
==========================================
- Hits          595      590       -5     
+ Misses        169      162       -7     
Impacted Files Coverage Δ
src/instrumentations/index.ts 100.00% <ø> (ø)
src/profiling/index.ts 18.84% <0.00%> (-0.34%) ⬇️
src/metrics/index.ts 92.39% <100.00%> (+1.76%) ⬆️
src/tracing/index.ts 98.27% <100.00%> (+3.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f2ed1b9...3cffaa1. Read the comment docs.

@rauno56 rauno56 changed the title feat: release GA feat: release 1.0 May 26, 2022
@rauno56 rauno56 changed the title feat: release 1.0 chore: release v1.0.0 May 27, 2022
@rauno56 rauno56 marked this pull request as ready for review May 27, 2022 12:14
@rauno56 rauno56 requested review from a team as code owners May 27, 2022 12:14
@rauno56 rauno56 force-pushed the release/v1.0.0 branch 3 times, most recently from 479273c to 3cffaa1 Compare June 3, 2022 11:15
Copy link
Contributor

@seemk seemk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Went over the README, a few remarks:

startTracing is destructive to Open Telemetry API globals. We provide the stopTracing method, but it won't revert to OTel API globals set before startTracing was run, it will only disable globals, which startTracing set.

We actually currently do not export stopTracing

@@ -1,5 +1,5 @@
<p align="center">
<img alt="Beta" src="https://img.shields.io/badge/status-beta-informational?style=for-the-badge">
<img alt="Stable" src="https://img.shields.io/badge/status-stable-informational?style=for-the-badge">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not related to this change, but the GitHub branch checks state is always PENDING, should replace it with https://img.shields.io/github/workflow/status/signalfx/splunk-otel-js/Continuous%20Integration/main

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Goodones! Fixed them.

@rauno56 rauno56 merged commit 5f7b713 into signalfx:main Jun 6, 2022
@rauno56 rauno56 deleted the release/v1.0.0 branch June 6, 2022 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants