-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: release v1.0.0 #476
Conversation
Codecov Report
@@ Coverage Diff @@
## main #476 +/- ##
==========================================
+ Coverage 77.87% 78.45% +0.57%
==========================================
Files 26 26
Lines 764 752 -12
Branches 170 170
==========================================
- Hits 595 590 -5
+ Misses 169 162 -7
Continue to review full report at Codecov.
|
479273c
to
3cffaa1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Went over the README, a few remarks:
startTracing is destructive to Open Telemetry API globals. We provide the stopTracing method, but it won't revert to OTel API globals set before startTracing was run, it will only disable globals, which startTracing set.
We actually currently do not export stopTracing
@@ -1,5 +1,5 @@ | |||
<p align="center"> | |||
<img alt="Beta" src="https://img.shields.io/badge/status-beta-informational?style=for-the-badge"> | |||
<img alt="Stable" src="https://img.shields.io/badge/status-stable-informational?style=for-the-badge"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not related to this change, but the GitHub branch checks state
is always PENDING
, should replace it with https://img.shields.io/github/workflow/status/signalfx/splunk-otel-js/Continuous%20Integration/main
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Goodones! Fixed them.
Description
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Checklist:
npm run change:new
)