Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add splunk.distro.version resource attribute #475

Merged
merged 4 commits into from
May 23, 2022

Conversation

rauno56
Copy link
Contributor

@rauno56 rauno56 commented May 20, 2022

Description

Adds splunk.distro.version resource attribute.

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

  • Added automated tests

Checklist:

  • Unit tests have been added/updated
  • Change file has been generated (npm run change:new)
  • Delete this branch (after the PR is merged)

@rauno56 rauno56 requested review from a team as code owners May 20, 2022 11:54
@codecov-commenter
Copy link

codecov-commenter commented May 20, 2022

Codecov Report

Merging #475 (29d6d15) into main (d8a13ba) will increase coverage by 0.24%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #475      +/-   ##
==========================================
+ Coverage   76.33%   76.57%   +0.24%     
==========================================
  Files          21       22       +1     
  Lines         676      683       +7     
  Branches      157      157              
==========================================
+ Hits          516      523       +7     
  Misses        160      160              
Impacted Files Coverage Δ
src/detectors/DistroDetector.ts 100.00% <100.00%> (ø)
src/resource.ts 88.23% <100.00%> (+0.73%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d8a13ba...29d6d15. Read the comment docs.

@rauno56 rauno56 force-pushed the feat/distro-version branch from 0aab1a8 to 5f9fead Compare May 20, 2022 12:33
@rauno56 rauno56 merged commit d5ae064 into signalfx:main May 23, 2022
@rauno56 rauno56 deleted the feat/distro-version branch May 23, 2022 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants