-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: set the GDI-spec compliant defs and warn about missing service.name #344
Conversation
Codecov Report
@@ Coverage Diff @@
## main #344 +/- ##
==========================================
+ Coverage 93.89% 94.05% +0.15%
==========================================
Files 10 10
Lines 344 353 +9
Branches 89 93 +4
==========================================
+ Hits 323 332 +9
Misses 21 21
Continue to review full report at Codecov.
|
9289631
to
98190a8
Compare
98190a8
to
4b894c7
Compare
defaultServiceName; | ||
resource.attributes[SemanticResourceAttributes.SERVICE_NAME]; | ||
|
||
if (!serviceName) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is diag.warn
visible in the terminal as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only if it's enabled.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll merge it, @seemk, but any comments are still welcome!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mistake in docs. Looks good otherwise.
Description
Addresses some of the concerns from GDI spec review.
Type of change
npm run change:new
)