-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update core OTel deps to v1.0 #334
Conversation
Codecov Report
@@ Coverage Diff @@
## main #334 +/- ##
=======================================
Coverage 93.89% 93.89%
=======================================
Files 10 10
Lines 344 344
Branches 89 89
=======================================
Hits 323 323
Misses 21 21
Continue to review full report at Codecov.
|
93af8ed
to
6366ca0
Compare
"opentelemetry-instrumentation-mongoose": ">=0.23.0 <1", | ||
"opentelemetry-instrumentation-sequelize": ">=0.23.0 <1", | ||
"opentelemetry-instrumentation-typeorm": ">=0.23.0 <1" | ||
"@opentelemetry/instrumentation-bunyan": ">=0.25.0 <1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is fine, but shouldn't @opentelemetry/instrumentation
have the same supported versions as @opentelemetry/instrumentation-*
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It doesn't have to. Different instrumentations can use (and as the ecosystem evolves will use) different versions of @opentelemetry/instrumentation
to build on for a starter.
We are actually depending on @opentelemetry/instrumentation
for the utils and types - little to do with which version of the package instrumentation libs are using.
2149430
to
dbad736
Compare
Description
Updating OTel deps to the latest versions. For many of them, it's v1.0.
Type of change
npm run change:new
)