Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update core OTel deps to v1.0 #334

Merged
merged 5 commits into from
Oct 6, 2021

Conversation

rauno56
Copy link
Contributor

@rauno56 rauno56 commented Oct 4, 2021

Description

Updating OTel deps to the latest versions. For many of them, it's v1.0.

Type of change

  • New feature (non-breaking change which adds functionality)
  • Internal change (a change which is not visible to the package consumers)
  • Change file has been generated (npm run change:new)
  • Delete this branch (after the PR is merged)

@codecov-commenter
Copy link

codecov-commenter commented Oct 4, 2021

Codecov Report

Merging #334 (76ffc7b) into main (e40de73) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 76ffc7b differs from pull request most recent head c59ebe3. Consider uploading reports for the commit c59ebe3 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##             main     #334   +/-   ##
=======================================
  Coverage   93.89%   93.89%           
=======================================
  Files          10       10           
  Lines         344      344           
  Branches       89       89           
=======================================
  Hits          323      323           
  Misses         21       21           
Impacted Files Coverage Δ
src/options.ts 98.93% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e40de73...c59ebe3. Read the comment docs.

@rauno56 rauno56 force-pushed the chore/update-otel-deps branch from 93af8ed to 6366ca0 Compare October 5, 2021 16:42
@jtmal-signalfx jtmal-signalfx self-requested a review October 6, 2021 09:20
"opentelemetry-instrumentation-mongoose": ">=0.23.0 <1",
"opentelemetry-instrumentation-sequelize": ">=0.23.0 <1",
"opentelemetry-instrumentation-typeorm": ">=0.23.0 <1"
"@opentelemetry/instrumentation-bunyan": ">=0.25.0 <1",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is fine, but shouldn't @opentelemetry/instrumentation have the same supported versions as @opentelemetry/instrumentation-*?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't have to. Different instrumentations can use (and as the ecosystem evolves will use) different versions of @opentelemetry/instrumentation to build on for a starter.
We are actually depending on @opentelemetry/instrumentation for the utils and types - little to do with which version of the package instrumentation libs are using.

@rauno56 rauno56 force-pushed the chore/update-otel-deps branch from 2149430 to dbad736 Compare October 6, 2021 14:46
@rauno56 rauno56 marked this pull request as ready for review October 6, 2021 14:56
@rauno56 rauno56 requested review from a team as code owners October 6, 2021 14:56
@rauno56 rauno56 changed the title chore: update OTel deps chore: update core OTel deps to v1.0 Oct 6, 2021
@rauno56 rauno56 merged commit 0b7a6d9 into signalfx:main Oct 6, 2021
@rauno56 rauno56 deleted the chore/update-otel-deps branch October 6, 2021 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants