Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use OTLP gRPC exporter by default #319

Merged
merged 19 commits into from
Oct 4, 2021

Conversation

rauno56
Copy link
Contributor

@rauno56 rauno56 commented Sep 28, 2021

Integration tests cannot work on this PR - those are using the latest published version of the package, which does not understand gRPC configuration which we are using for both e2e test variants.

Description

Replacing OTLP/HTTP exporters with OTLP/gRPC(for the main default) and Jaeger(for collectorless) tandem.

  • POR-9648
  • POR-9649

Type of change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation change or requires a documentation update
  • Added automated tests
  • Unit tests have been added/updated
  • Documentation has been updated
  • Change file has been generated (npm run change:new)
  • Delete this branch (after the PR is merged)

@rauno56
Copy link
Contributor Author

rauno56 commented Sep 29, 2021

@theletterf, could you please proofread the changed docs?

@codecov-commenter
Copy link

codecov-commenter commented Sep 29, 2021

Codecov Report

Merging #319 (1b1d6cb) into main (0347c10) will increase coverage by 0.07%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #319      +/-   ##
==========================================
+ Coverage   93.82%   93.89%   +0.07%     
==========================================
  Files          10       10              
  Lines         340      344       +4     
  Branches       88       89       +1     
==========================================
+ Hits          319      323       +4     
  Misses         21       21              
Impacted Files Coverage Δ
src/options.ts 98.93% <100.00%> (+0.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0347c10...1b1d6cb. Read the comment docs.

MIGRATING.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
docs/correlate-logs-traces.md Outdated Show resolved Hide resolved
examples/basic/README.md Outdated Show resolved Hide resolved
examples/express/README.md Outdated Show resolved Hide resolved
examples/express/README.md Outdated Show resolved Hide resolved
examples/express/README.md Outdated Show resolved Hide resolved
examples/express/README.md Outdated Show resolved Hide resolved
examples/express/README.md Outdated Show resolved Hide resolved
examples/express/README.md Outdated Show resolved Hide resolved
@rauno56
Copy link
Contributor Author

rauno56 commented Sep 30, 2021

Nice! Thanks for all the copy suggestions, @theletterf!

Actually already a dep of the grpc exporter, but required to satisfy
the lint.
@rauno56 rauno56 marked this pull request as ready for review September 30, 2021 14:53
@rauno56 rauno56 requested review from a team as code owners September 30, 2021 14:53
package-lock.json Outdated Show resolved Hide resolved
package.json Outdated
@@ -90,10 +90,11 @@
"winston": "3.3.3"
},
"dependencies": {
"@grpc/grpc-js": "^1.3.7",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we be sure future versions of exporter-collector-grpc will have a compatible version of @grpc/grpc-js? Is the dependency explicitly needed if the exporter depends on one?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The version of this should be updated with the exporter - this range is what was specified on the exporter.

The dep isn't explicitly needed, added it when lint pointed that out. Although, the only real reason to actually do that in our case is to avoid a situation where the exporter removes the dep which breaks us. Even if we do add the dep, it causes undefined behaviour because the exporter will not be compatible anymore.

Removing the dep and adding the lint exception makes more sense to me now - WDYT?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See bfb7d93.

@rauno56 rauno56 merged commit b75e389 into signalfx:main Oct 4, 2021
@rauno56 rauno56 deleted the feat/otlp-grpc branch October 4, 2021 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants