Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add resource attributes #316

Merged
merged 42 commits into from
Oct 1, 2021
Merged

Add resource attributes #316

merged 42 commits into from
Oct 1, 2021

Conversation

theletterf
Copy link
Contributor

No description provided.

@theletterf theletterf requested review from a team as code owners September 28, 2021 11:27
@rauno56
Copy link
Contributor

rauno56 commented Sep 28, 2021

👍 This becomes reality with #312
I will leave it open for now.

@codecov-commenter
Copy link

codecov-commenter commented Sep 29, 2021

Codecov Report

Merging #316 (6cbf52c) into main (40f3c60) will not change coverage.
The diff coverage is n/a.

❗ Current head 6cbf52c differs from pull request most recent head 24d9dfc. Consider uploading reports for the commit 24d9dfc to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##             main     #316   +/-   ##
=======================================
  Coverage   92.81%   92.81%           
=======================================
  Files          10       10           
  Lines         348      348           
  Branches       90       90           
=======================================
  Hits          323      323           
  Misses         25       25           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 40f3c60...24d9dfc. Read the comment docs.

@rauno56 rauno56 merged commit 2df498f into signalfx:main Oct 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants