-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: update docs for the GA #279
Conversation
Codecov Report
@@ Coverage Diff @@
## main #279 +/- ##
=======================================
Coverage 94.89% 94.89%
=======================================
Files 10 10
Lines 294 294
Branches 75 75
=======================================
Hits 279 279
Misses 15 15 Continue to review full report at Codecov.
|
All the current options are defined in README. See it in the code here: https://github.com/signalfx/splunk-otel-js/blob/main/src/options.ts#L49-L61 to double-check.
Most of the settings have both. The difference is only in options that do not make sense as an env var - when the thing you need to provide is a function or an object. There's no preferred way I'd say. Env is easier to get off the ground with. The programmatic way gives you better control. I'd say it's always better to go with former as long as it's sufficient for your usecase.
We auto-instrument popular logging libs, but you have to use one of those to get the correlation - which kinda makes sense, there's no reasonable way to know you're logging to stdout without those. The config options are documented, but no deeper context is given - we expect the user to know what "log injection" means and does. There are also tests for those that might give you an idea how they work and what do expect.
There's a list in the readme. Incomplete one though because we support everything that's officially supported by OTel and that list is constantly growing. See
Enabling diagnostics logging is shown in the express example.
We have https://github.com/signalfx/splunk-otel-js/blob/main/RELEASING.md.
* I made this number up.
Just like for any other language distro they are an automatic way to generate library-specific spans. They give insight into the usage of the instrumented library with virtually 0 effort! See the examples. |
@rauno56 For GA, I think that the only docs that you need is adding a Troubleshooting section the README, which would benefit me greatly, too. Following what Python and Java did, I suggest that you also add a section on correlating traces and logs. For example, see https://github.com/signalfx/splunk-otel-java/blob/main/docs/correlating-traces-with-logs.md I believe it is a requirement also to document all settings/config params: https://github.com/signalfx/gdi-specification/blob/main/specification/repository.md#data-collector. An example you'd follow is what the Java team did, with ENV vars and their runtime equivalents: https://github.com/signalfx/splunk-otel-java/blob/main/docs/advanced-config.md Those pieces I can review and help improve, but the raw input to the repo must come from you. (I'd try and build the tables of settings based on what's in the README, but I might miss something. In any case, you should pull the settings from there and put them in a separate page.) How does the above sound? |
Co-authored-by: Rauno Viskus <[email protected]>
Create a docs folder. Inside there should be:
Additionally:
SPLUNK_MAX_ATTR_LENGTH
. Prefer the native OTel env vars instead which will be soon merged in upstream.