chore: deprecate SPLUNK_SERVICE_NAME #170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead use OTel's OTEL_SERVICE_NAME
rauno56
approved these changes
Jul 7, 2021
seemk
approved these changes
Jul 8, 2021
| @@ -154,6 +157,8 @@ describe('tracing', () => { | |||
| maxAttrLength, | |||
| logInjectionEnabled | |||
| ); | |||
| stopTracing(); | |||
There was a problem hiding this comment.
What was the reason stopTracing was added to tests? Here and at loginjection
There was a problem hiding this comment.
Well, so I made a mistake while coding, and I mistakenly thought that the tests were not passing because another test was overwriting the globals. However, I left stopTracing in place because deregistering is necessary for some tests in signalfx/otel-js-web, so I'm expecting that sooner or later it will be needed in this library too.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use OTel's
OTEL_SERVICE_NAMEinstead ofSPLUNK_SERVICE_NAMEDescription
Correcting this unnecessary divergence from the standard.
Also, needed for smoother migration process (#168)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Checklist: