Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for Synthetics-RunId #156

Merged
merged 3 commits into from
Jul 13, 2021
Merged

Support for Synthetics-RunId #156

merged 3 commits into from
Jul 13, 2021

Conversation

jtmalinowski
Copy link
Contributor

@jtmalinowski jtmalinowski commented Jun 29, 2021 •
edited by jtmal-signalfx
Loading

Description

Splunk Synthetic Monitoring want to use a dedicated baggage field to mark traces as synthetic. Propagate this field using baggage, and set as an attribute on appropriate spans.

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

  • Tested manually
  • Added automated tests

Checklist:

  • Changelogs have been updated
  • Unit tests have been added/updated
  • Documentation has been updated

@jtmal-signalfx
Support for Synthetics-RunId
3c79c4d 
Propagate this field using baggage, and set as an attribute.
@jtmalinowski jtmalinowski requested a review from owais as a code owner June 29, 2021 15:28
@jtmal-signalfx jtmal-signalfx requested review from seemk and rauno56 June 30, 2021 13:34
rauno56
rauno56 reviewed Jul 2, 2021
View reviewed changes
Copy link
Contributor

@rauno56 rauno56 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!
Since I'm not familiar with the concept: It basically adds a Splunk-standard Synthetics-RunId field to baggage to be propagated around. Based on that field the backend can then filter out test runs. Accurate?
Is there any docs/material on this?

@jtmalinowski jtmalinowski marked this pull request as draft July 2, 2021 16:54
@jtmalinowski
Copy link
Contributor Author

The decision to use baggage is to be rereviewed.

@rauno56
Copy link
Contributor

rauno56 commented Jul 8, 2021

The decision to use baggage is to be rereviewed.

What's the alternative?

@jtmalinowski
Copy link
Contributor Author

@rauno56 Tracestate for one. But we cleared the baggage for use here.

@jtmalinowski jtmalinowski marked this pull request as ready for review July 12, 2021 15:32
@jtmalinowski jtmalinowski requested review from a team as code owners July 12, 2021 15:32
@jtmal-signalfx jtmal-signalfx merged commit 9c2b84c into signalfx:main Jul 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rauno56 rauno56 rauno56 approved these changes

@owais owais Awaiting requested review from owais

@seemk seemk Awaiting requested review from seemk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jtmalinowski @rauno56 @jtmal-signalfx