Add oracle context propagation#2434
Merged
laurit merged 2 commits intosignalfx:mainfrom Sep 9, 2025
Merged
Conversation
breedx-splk
reviewed
Sep 8, 2025
| statement.setBytes(1, contextInfo); | ||
| statement.executeUpdate(); | ||
| } | ||
| protected abstract void setContext(Connection connection, String contextInfo) throws SQLException; |
Contributor
There was a problem hiding this comment.
Even if it's assumed (and we don't use the non-null-by-default thing), might be nice to have this called out.
Suggested change
| protected abstract void setContext(Connection connection, String contextInfo) throws SQLException; | |
| protected abstract void setContext(Connection connection, @Nullable String contextInfo) throws SQLException; |
breedx-splk
reviewed
Sep 8, 2025
| import java.util.concurrent.atomic.AtomicReference; | ||
|
|
||
| public final class SqlServerUtil { | ||
| public abstract class AbstractDbContextPropagator { |
Contributor
There was a problem hiding this comment.
We've worked together long enough that you know. 🙃
breedx-splk
approved these changes
Sep 8, 2025
Contributor
breedx-splk
left a comment
breedx-splk
left a comment
There was a problem hiding this comment.
Thanks for working it out.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on #2405