Skip to content

Remove smartagent collectd/protocols monitor#7383

Merged
pjanotti merged 3 commits into
mainfrom
remove-collectd-protocols
Apr 2, 2026
Merged

Remove smartagent collectd/protocols monitor#7383
pjanotti merged 3 commits into
mainfrom
remove-collectd-protocols

Conversation

@pjanotti

@pjanotti pjanotti commented Apr 1, 2026

Copy link
Copy Markdown
Contributor

Remove smartagent collectd/protocols monitor

@pjanotti pjanotti requested review from a team as code owners April 1, 2026 18:38
Copilot AI review requested due to automatic review settings April 1, 2026 18:38
@pjanotti pjanotti requested a review from a team as a code owner April 1, 2026 18:38

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes the deprecated Smart Agent monitor collectd/protocols from the embedded SignalFx Agent monitor set, aligning with the end of its deprecation period and steering users to the hostmetrics network scraper replacement.

Changes:

  • Deleted the collectd/protocols monitor implementation, templates, and generated metadata.
  • Unregistered the monitor from Linux module imports so it’s no longer available at runtime.
  • Added a breaking-change changelog entry documenting removal and the recommended replacement.

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.

Show a summary per file
File Description
pkg/receiver/smartagentreceiver/config.go Drops collectd/protocols from the Windows “unsupported monitors” map since the monitor is removed.
internal/signalfx-agent/pkg/monitors/collectd/protocols/template.go Removes the generated collectd config template for the protocols monitor.
internal/signalfx-agent/pkg/monitors/collectd/protocols/protocols.tmpl Removes the source collectd template file for the protocols monitor.
internal/signalfx-agent/pkg/monitors/collectd/protocols/protocols.go Removes the monitor registration and configuration logic.
internal/signalfx-agent/pkg/monitors/collectd/protocols/metadata.yaml Removes monitor metadata and metric definitions for collectd/protocols.
internal/signalfx-agent/pkg/monitors/collectd/protocols/genmetadata.go Removes generated metadata code used by monitor registration/introspection.
internal/signalfx-agent/pkg/core/modules_linux.go Removes the blank import that registered collectd/protocols on Linux builds.
.chloggen/remove-collectd-protocols.yaml Adds a breaking-change entry announcing removal and pointing to hostmetrics network scraper.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov

codecov Bot commented Apr 1, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 26.04%. Comparing base (afbfc43) to head (f8b34eb).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7383      +/-   ##
==========================================
+ Coverage   25.99%   26.04%   +0.04%     
==========================================
  Files         319      318       -1     
  Lines       22934    22926       -8     
==========================================
+ Hits         5962     5970       +8     
+ Misses      16291    16279      -12     
+ Partials      681      677       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copilot AI review requested due to automatic review settings April 2, 2026 22:46

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@pjanotti pjanotti merged commit 29b36b4 into main Apr 2, 2026
283 of 286 checks passed
@pjanotti pjanotti deleted the remove-collectd-protocols branch April 2, 2026 23:24
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 2, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants