Remove smartagent collectd/protocols monitor#7383
Conversation
There was a problem hiding this comment.
Pull request overview
Removes the deprecated Smart Agent monitor collectd/protocols from the embedded SignalFx Agent monitor set, aligning with the end of its deprecation period and steering users to the hostmetrics network scraper replacement.
Changes:
- Deleted the
collectd/protocolsmonitor implementation, templates, and generated metadata. - Unregistered the monitor from Linux module imports so it’s no longer available at runtime.
- Added a breaking-change changelog entry documenting removal and the recommended replacement.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| pkg/receiver/smartagentreceiver/config.go | Drops collectd/protocols from the Windows “unsupported monitors” map since the monitor is removed. |
| internal/signalfx-agent/pkg/monitors/collectd/protocols/template.go | Removes the generated collectd config template for the protocols monitor. |
| internal/signalfx-agent/pkg/monitors/collectd/protocols/protocols.tmpl | Removes the source collectd template file for the protocols monitor. |
| internal/signalfx-agent/pkg/monitors/collectd/protocols/protocols.go | Removes the monitor registration and configuration logic. |
| internal/signalfx-agent/pkg/monitors/collectd/protocols/metadata.yaml | Removes monitor metadata and metric definitions for collectd/protocols. |
| internal/signalfx-agent/pkg/monitors/collectd/protocols/genmetadata.go | Removes generated metadata code used by monitor registration/introspection. |
| internal/signalfx-agent/pkg/core/modules_linux.go | Removes the blank import that registered collectd/protocols on Linux builds. |
| .chloggen/remove-collectd-protocols.yaml | Adds a breaking-change entry announcing removal and pointing to hostmetrics network scraper. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7383 +/- ##
==========================================
+ Coverage 25.99% 26.04% +0.04%
==========================================
Files 319 318 -1
Lines 22934 22926 -8
==========================================
+ Hits 5962 5970 +8
+ Misses 16291 16279 -12
+ Partials 681 677 -4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 9 out of 9 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Remove smartagent
collectd/protocolsmonitor