remove kubeletstats config converter#6815
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR removes the kubeletstats config converter that automatically disabled deprecated CPU utilization metrics, as these metrics no longer exist in OpenTelemetry Collector Contrib v0.136.0.
- Removes the
DisableKubeletUtilizationMetricsconfig converter from the settings factory - Deletes the entire implementation and test suite for the kubeletstats utilization metrics converter
- Updates changelog to document the removal of deprecated metrics from the upstream collector
Reviewed Changes
Copilot reviewed 17 out of 17 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| internal/settings/settings.go | Removes reference to kubeletstats config converter factory |
| internal/configconverter/disable_kubelet_utilization_metrics.go | Complete removal of converter implementation |
| internal/configconverter/disable_kubelet_utilization_metrics_test.go | Removes all tests for the converter |
| internal/configconverter/testdata/disable_kubelet_utilization_metrics/*.yaml | Removes all test data files |
| CHANGELOG.md | Documents upstream removal of deprecated metrics |
| .chloggen/remove-kubeletstats-utilization-converter.yaml | Changelog entry for this breaking change |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
skipping the changelog check because it does not let manual edits to CHANGELOG file |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6815 +/- ##
==========================================
- Coverage 43.59% 43.23% -0.36%
==========================================
Files 376 369 -7
Lines 26363 26088 -275
==========================================
- Hits 11492 11280 -212
+ Misses 14040 13992 -48
+ Partials 831 816 -15 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
crobert-1
left a comment
There was a problem hiding this comment.
It looks like all files under internal/configconverter/dpfilters were copied from the SignalFx exporter to enable this config converter:
// Temporary copied from the SignalFx exporter to be used in DisableKubeletUtilizationMetrics converter.
I believe the whole directory can be removed, but it'd have to be tested to make sure there aren't other references.
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 18 out of 18 changed files in this pull request and generated no new comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 28 out of 28 changed files in this pull request and generated no new comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
crobert-1
left a comment
There was a problem hiding this comment.
LGTM as long as tests pass 👍
Co-authored-by: Curtis Robert <crobert@splunk.com>
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 28 out of 28 changed files in this pull request and generated no new comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 28 out of 28 changed files in this pull request and generated no new comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 29 out of 29 changed files in this pull request and generated no new comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Description:
Remove kubeletstats config converter which is adding no longer existing metric options