Skip to content

remove kubeletstats config converter#6815

Merged
jinja2 merged 11 commits into
mainfrom
rm-configconv-k8s
Sep 30, 2025
Merged

remove kubeletstats config converter#6815
jinja2 merged 11 commits into
mainfrom
rm-configconv-k8s

Conversation

@jinja2
Copy link
Copy Markdown
Contributor

@jinja2 jinja2 commented Sep 30, 2025

Description:

Remove kubeletstats config converter which is adding no longer existing metric options

@jinja2 jinja2 requested a review from a team as a code owner September 30, 2025 16:51
Copilot AI review requested due to automatic review settings September 30, 2025 16:51
@jinja2 jinja2 requested review from a team as code owners September 30, 2025 16:51
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes the kubeletstats config converter that automatically disabled deprecated CPU utilization metrics, as these metrics no longer exist in OpenTelemetry Collector Contrib v0.136.0.

  • Removes the DisableKubeletUtilizationMetrics config converter from the settings factory
  • Deletes the entire implementation and test suite for the kubeletstats utilization metrics converter
  • Updates changelog to document the removal of deprecated metrics from the upstream collector

Reviewed Changes

Copilot reviewed 17 out of 17 changed files in this pull request and generated no comments.

Show a summary per file
File Description
internal/settings/settings.go Removes reference to kubeletstats config converter factory
internal/configconverter/disable_kubelet_utilization_metrics.go Complete removal of converter implementation
internal/configconverter/disable_kubelet_utilization_metrics_test.go Removes all tests for the converter
internal/configconverter/testdata/disable_kubelet_utilization_metrics/*.yaml Removes all test data files
CHANGELOG.md Documents upstream removal of deprecated metrics
.chloggen/remove-kubeletstats-utilization-converter.yaml Changelog entry for this breaking change

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@jinja2 jinja2 added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Sep 30, 2025
@jinja2
Copy link
Copy Markdown
Contributor Author

jinja2 commented Sep 30, 2025

skipping the changelog check because it does not let manual edits to CHANGELOG file

@codecov
Copy link
Copy Markdown

codecov Bot commented Sep 30, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 43.23%. Comparing base (fa49743) to head (5fd797f).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6815      +/-   ##
==========================================
- Coverage   43.59%   43.23%   -0.36%     
==========================================
  Files         376      369       -7     
  Lines       26363    26088     -275     
==========================================
- Hits        11492    11280     -212     
+ Misses      14040    13992      -48     
+ Partials      831      816      -15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Contributor

@crobert-1 crobert-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like all files under internal/configconverter/dpfilters were copied from the SignalFx exporter to enable this config converter:

// Temporary copied from the SignalFx exporter to be used in DisableKubeletUtilizationMetrics converter.

I believe the whole directory can be removed, but it'd have to be tested to make sure there aren't other references.

Copilot AI review requested due to automatic review settings September 30, 2025 17:29
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 18 out of 18 changed files in this pull request and generated no new comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copilot AI review requested due to automatic review settings September 30, 2025 17:49
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 28 out of 28 changed files in this pull request and generated no new comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link
Copy Markdown
Contributor

@crobert-1 crobert-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as long as tests pass 👍

Comment thread .chloggen/remove-kubeletstats-utilization-converter.yaml Outdated
Co-authored-by: Curtis Robert <crobert@splunk.com>
Copilot AI review requested due to automatic review settings September 30, 2025 18:34
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 28 out of 28 changed files in this pull request and generated no new comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread CHANGELOG.md Outdated
Comment thread .chloggen/remove-kubeletstats-utilization-converter.yaml
Comment thread .chloggen/remove-kubeletstats-utilization-converter.yaml Outdated
Copy link
Copy Markdown
Contributor

@dmitryax dmitryax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT

Copilot AI review requested due to automatic review settings September 30, 2025 19:28
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 28 out of 28 changed files in this pull request and generated no new comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copilot AI review requested due to automatic review settings September 30, 2025 21:23
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 29 out of 29 changed files in this pull request and generated no new comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@jinja2 jinja2 merged commit 9ba2755 into main Sep 30, 2025
276 of 277 checks passed
@jinja2 jinja2 deleted the rm-configconv-k8s branch September 30, 2025 23:03
@github-actions github-actions Bot locked and limited conversation to collaborators Sep 30, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Skip Changelog PRs that do not require a CHANGELOG.md entry

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants