Skip to content

[chore][tests/receiver/kong] Remove redundant tests#6775

Merged
crobert-1 merged 1 commit into
signalfx:mainfrom
crobert-1:remove_kong_tests
Sep 17, 2025
Merged

[chore][tests/receiver/kong] Remove redundant tests#6775
crobert-1 merged 1 commit into
signalfx:mainfrom
crobert-1:remove_kong_tests

Conversation

@crobert-1
Copy link
Copy Markdown
Contributor

Description:

This was a golden test for metrics coming from a Kong gateway, by way of the Prometheus receiver. None of this functionality is specific to our distro, so the test was moved upstream in open-telemetry/opentelemetry-collector-contrib#42741. Now that the test exists upstream we can remove from our repo.

@crobert-1 crobert-1 requested review from a team as code owners September 17, 2025 15:09
@codecov
Copy link
Copy Markdown

codecov Bot commented Sep 17, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 43.71%. Comparing base (f854fd4) to head (343deb3).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6775      +/-   ##
==========================================
- Coverage   43.72%   43.71%   -0.02%     
==========================================
  Files         376      376              
  Lines       26363    26363              
==========================================
- Hits        11527    11524       -3     
- Misses      14013    14015       +2     
- Partials      823      824       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Contributor

@pjanotti pjanotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, the failure at first sounds unrelated, but it would be good to confirm before merging:

2025-09-17T15:24:39.2191080Z === RUN   TestConfigServer_RequireEnvVar
2025-09-17T15:24:39.2191359Z     config_server_test.go:55: 
2025-09-17T15:24:39.2192002Z         	Error Trace:	D:/a/splunk-otel-collector/splunk-otel-collector/internal/configconverter/config_server_test.go:55
2025-09-17T15:24:39.2192662Z         	Error:      	An error is expected but got nil.
2025-09-17T15:24:39.2193089Z         	Test:       	TestConfigServer_RequireEnvVar

@crobert-1 crobert-1 merged commit 86c4195 into signalfx:main Sep 17, 2025
95 of 101 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators Sep 17, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants