[chore][tests/receiver/kong] Remove redundant tests#6775
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6775 +/- ##
==========================================
- Coverage 43.72% 43.71% -0.02%
==========================================
Files 376 376
Lines 26363 26363
==========================================
- Hits 11527 11524 -3
- Misses 14013 14015 +2
- Partials 823 824 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
pjanotti
approved these changes
Sep 17, 2025
Contributor
pjanotti
left a comment
There was a problem hiding this comment.
LGTM, the failure at first sounds unrelated, but it would be good to confirm before merging:
2025-09-17T15:24:39.2191080Z === RUN TestConfigServer_RequireEnvVar
2025-09-17T15:24:39.2191359Z config_server_test.go:55:
2025-09-17T15:24:39.2192002Z Error Trace: D:/a/splunk-otel-collector/splunk-otel-collector/internal/configconverter/config_server_test.go:55
2025-09-17T15:24:39.2192662Z Error: An error is expected but got nil.
2025-09-17T15:24:39.2193089Z Test: TestConfigServer_RequireEnvVar
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
This was a golden test for metrics coming from a Kong gateway, by way of the Prometheus receiver. None of this functionality is specific to our distro, so the test was moved upstream in open-telemetry/opentelemetry-collector-contrib#42741. Now that the test exists upstream we can remove from our repo.