Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6515 +/- ##
==========================================
+ Coverage 44.03% 44.04% +0.01%
==========================================
Files 376 376
Lines 26459 26459
==========================================
+ Hits 11650 11653 +3
+ Misses 13980 13978 -2
+ Partials 829 828 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| Request context is now preserved by default when using persistent queues. | ||
| Note that Auth extensions context is not propagated through the persistent queue. | ||
|
|
||
| - (Core) `pdata`: Use pdatagen to generate marshalJSON without using gogo proto jsonpb. ([#13450](https://github.com/open-telemetry/opentelemetry-collector/pull/13450)) |
There was a problem hiding this comment.
I don't think this directly matters to our users.
Same for the line below.
There was a problem hiding this comment.
More generally we try to list changes not directly visible to our users, so API and internal changes are typically not included.
There was a problem hiding this comment.
I was not aware that this is the approach we follow.
Back in SWAT, we used to look at the changelog when run into bugs related to internal components, I think it's very useful and speed up the process of not looking at code
There was a problem hiding this comment.
hum but it is not what we have been doing, I'm fine as long as we start to do it consistently. It does simplify the process on our side.
There was a problem hiding this comment.
anyway, my intention is similar to #6515 (comment)
so I guess we are still trying to remove some of those, the Q is that there is always a bit of judgement here
There was a problem hiding this comment.
I figure the customers could always skim past it if not. Personally, if I'm looking through change logs I'd want to know all the context that changed and not less.
I'd imagine the intended audience for these Changelogs are other developers and not, like, product. Even if it is product, I'd imagine they're just searching for anything which piques their interest, and they can just skim over this line, because they see it marked as pdata and thus wouldn't care about it
|
|
||
| ### 🛑 Breaking changes 🛑 | ||
|
|
||
| - (Splunk) `discovery`: Move `splunk.continuousDiscovery` feature flag to stable |
There was a problem hiding this comment.
does this change (continuousDiscovery one) have any implication for a user upgrading? i think there was some discussion about disallowing customized rules? is that the breaking change?
f9272d8 to
c460cac
Compare
|
In the latest push, I have added the upstream changelogs links |
Signed-off-by: Dani Louca <dlouca@splunk.com>
Description:
Link to Splunk idea: <Link to Splunk idea, see https://ideas.splunk.com>
Testing:
Documentation: