[chart] Address deprecation warnings#2326
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the Splunk OpenTelemetry Collector for Kubernetes Helm chart (and its related tests/examples) to use the non-deprecated OpenTelemetry Collector component names (e.g., otlp_http, k8s_attributes) to eliminate deprecation warnings at runtime.
Changes:
- Replace deprecated component aliases (
otlphttp,k8sattributes) with separated component names (otlp_http,k8s_attributes) in chart templates and values docs. - Update unit/functional tests and golden files to reflect new component IDs.
- Regenerate example rendered manifests (checksums/config) and add a new
histogram-exampleexample set.
Reviewed changes
Copilot reviewed 143 out of 143 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| unittests/k8sentities_test.yaml | Updates assertions to expect otlp_http/... exporter IDs. |
| helm-charts/splunk-otel-collector/values.yaml | Updates in-chart documentation text to refer to otlp_http. |
| helm-charts/splunk-otel-collector/templates/config/_otel-k8s-cluster-receiver-config.tpl | Renames exporter and processor references to otlp_http / k8s_attributes in cluster receiver config. |
| helm-charts/splunk-otel-collector/templates/config/_otel-collector.tpl | Renames core collector pipeline references to otlp_http / k8s_attributes. |
| helm-charts/splunk-otel-collector/templates/config/_otel-agent.tpl | Renames agent pipeline references/comments to otlp_http / k8s_attributes. |
| helm-charts/splunk-otel-collector/templates/config/_common.tpl | Renames shared exporter/processor component keys to otlp_http / k8s_attributes. |
| helm-charts/splunk-otel-collector/templates/_helpers.tpl | Updates helper docstring to reference otlp_http. |
| helm-charts/splunk-otel-collector/ci/sampler-gateway-env-vars-java-logs-values.yaml | Updates sample config to use k8s_attributes. |
| functional_tests/token_passthrough/testdata/agent_with_gateway_values.tmpl | Updates test values to use otlp_http. |
| functional_tests/token_passthrough/testdata/agent_only_values.tmpl | Updates test values to use otlp_http. |
| functional_tests/k8sevents/k8sevents_test.go | Updates comment to reference k8s_attributes. |
| functional_tests/k8sentities/k8sentities_test.go | Updates comments to reference otlp_http. |
| functional_tests/functional/testdata/expected_kind_values/expected_internal_metrics.yaml | Updates expected internal metrics labels for new component IDs. |
| functional_tests/discovery/testdata/agent_with_gateway_values.tmpl | Updates test values to use otlp_http/entities. |
| functional_tests/discovery/testdata/agent_only_values.tmpl | Updates test values to use otlp_http/entities. |
| examples/with-target-allocator/rendered_manifests/daemonset.yaml | Regenerated rendered manifest checksum after config changes. |
| examples/with-target-allocator/rendered_manifests/configmap-agent.yaml | Regenerated rendered manifest with otlp_http / k8s_attributes. |
| examples/use-proxy/rendered_manifests/daemonset.yaml | Regenerated rendered manifest checksum after config changes. |
| examples/use-proxy/rendered_manifests/configmap-agent.yaml | Regenerated rendered manifest with otlp_http / k8s_attributes. |
| examples/target-allocator/rendered_manifests/daemonset.yaml | Regenerated rendered manifest checksum after config changes. |
| examples/target-allocator/rendered_manifests/configmap-agent.yaml | Regenerated rendered manifest with otlp_http / k8s_attributes. |
| examples/splunk-platform-with-sourcetypes/rendered_manifests/deployment-cluster-receiver.yaml | Regenerated rendered manifest checksum after config changes. |
| examples/splunk-platform-with-sourcetypes/rendered_manifests/daemonset.yaml | Regenerated rendered manifest checksum after config changes. |
| examples/splunk-platform-with-sourcetypes/rendered_manifests/configmap-cluster-receiver.yaml | Regenerated rendered manifest with k8s_attributes/metrics. |
| examples/splunk-platform-with-sourcetypes/rendered_manifests/configmap-agent.yaml | Regenerated rendered manifest with k8s_attributes updates. |
| examples/splunk-enterprise-index-routing/rendered_manifests/daemonset.yaml | Regenerated rendered manifest checksum after config changes. |
| examples/splunk-enterprise-index-routing/rendered_manifests/configmap-agent.yaml | Regenerated rendered manifest with k8s_attributes. |
| examples/secureapp-gateway-mode/rendered_manifests/deployment-gateway.yaml | Regenerated rendered manifest checksum after config changes. |
| examples/secureapp-gateway-mode/rendered_manifests/configmap-gateway.yaml | Regenerated rendered manifest with otlp_http / k8s_attributes. |
| examples/secureapp-agent-mode/rendered_manifests/daemonset.yaml | Regenerated rendered manifest checksum after config changes. |
| examples/secureapp-agent-mode/rendered_manifests/configmap-agent.yaml | Regenerated rendered manifest with otlp_http / k8s_attributes. |
| examples/secret-validation/rendered_manifests/daemonset.yaml | Regenerated rendered manifest checksum after config changes. |
| examples/secret-validation/rendered_manifests/configmap-agent.yaml | Regenerated rendered manifest with k8s_attributes. |
| examples/route-data-through-gateway-deployed-separately/rendered_manifests/daemonset.yaml | Regenerated rendered manifest checksum after config changes. |
| examples/route-data-through-gateway-deployed-separately/rendered_manifests/configmap-agent.yaml | Regenerated rendered manifest with otlp_http / k8s_attributes. |
| examples/otlp-token-passthrough/rendered_manifests/deployment-gateway.yaml | Regenerated rendered manifest checksum after config changes. |
| examples/otlp-token-passthrough/rendered_manifests/daemonset.yaml | Regenerated rendered manifest checksum after config changes. |
| examples/otlp-token-passthrough/rendered_manifests/configmap-gateway.yaml | Regenerated rendered manifest with otlp_http / k8s_attributes. |
| examples/otlp-token-passthrough/rendered_manifests/configmap-agent.yaml | Regenerated rendered manifest with otlp_http/entities / k8s_attributes. |
| examples/only-traces/rendered_manifests/daemonset.yaml | Regenerated rendered manifest checksum after config changes. |
| examples/only-traces/rendered_manifests/configmap-agent.yaml | Regenerated rendered manifest with otlp_http / k8s_attributes. |
| examples/only-metrics/rendered_manifests/daemonset.yaml | Regenerated rendered manifest checksum after config changes. |
| examples/only-metrics/rendered_manifests/configmap-agent.yaml | Regenerated rendered manifest with otlp_http/entities / k8s_attributes. |
| examples/only-metrics-platform/rendered_manifests/deployment-cluster-receiver.yaml | Regenerated rendered manifest checksum after config changes. |
| examples/only-metrics-platform/rendered_manifests/daemonset.yaml | Regenerated rendered manifest checksum after config changes. |
| examples/only-metrics-platform/rendered_manifests/configmap-cluster-receiver.yaml | Regenerated rendered manifest with k8s_attributes/metrics. |
| examples/only-metrics-platform/rendered_manifests/configmap-agent.yaml | Regenerated rendered manifest with k8s_attributes/metrics. |
| examples/only-logs-with-extra-file-logs/rendered_manifests/daemonset.yaml | Regenerated rendered manifest checksum after config changes. |
| examples/only-logs-with-extra-file-logs/rendered_manifests/configmap-agent.yaml | Regenerated rendered manifest with k8s_attributes. |
| examples/multiline-logs/rendered_manifests/daemonset.yaml | Regenerated rendered manifest checksum after config changes. |
| examples/multiline-logs/rendered_manifests/configmap-agent.yaml | Regenerated rendered manifest with k8s_attributes. |
| examples/multi-metrics/rendered_manifests/deployment-cluster-receiver.yaml | Regenerated rendered manifest checksum after config changes. |
| examples/multi-metrics/rendered_manifests/daemonset.yaml | Regenerated rendered manifest checksum after config changes. |
| examples/multi-metrics/rendered_manifests/configmap-cluster-receiver.yaml | Regenerated rendered manifest with k8s_attributes/metrics. |
| examples/multi-metrics/rendered_manifests/configmap-agent.yaml | Regenerated rendered manifest with k8s_attributes/metrics. |
| examples/kubernetes-windows-nodes/rendered_manifests/daemonset.yaml | Regenerated rendered manifest checksum after config changes. |
| examples/kubernetes-windows-nodes/rendered_manifests/configmap-agent.yaml | Regenerated rendered manifest with otlp_http / k8s_attributes. |
| examples/k8s-events-o11y-pipeline/rendered_manifests/deployment-cluster-receiver.yaml | Regenerated rendered manifest checksum after config changes. |
| examples/k8s-events-o11y-pipeline/rendered_manifests/configmap-cluster-receiver.yaml | Regenerated rendered manifest with otlp_http/o11y_events. |
| examples/k8s-events-o11y-pipeline/k8s-events-o11y-pipeline-values.yaml | Updates example values docs to reference otlp_http/o11y_events. |
| examples/k8s-events-o11y-pipeline/README.md | Updates example README to reference otlp_http/o11y_events. |
| examples/host-journalctl-logs/rendered_manifests/daemonset.yaml | Regenerated rendered manifest checksum after config changes. |
| examples/host-journalctl-logs/rendered_manifests/configmap-agent.yaml | Regenerated rendered manifest with k8s_attributes. |
| examples/histograms-with-splunk-platform/rendered_manifests/deployment-cluster-receiver.yaml | Regenerated rendered manifest checksum after config changes. |
| examples/histograms-with-splunk-platform/rendered_manifests/daemonset.yaml | Regenerated rendered manifest checksum after config changes. |
| examples/histograms-with-splunk-platform/rendered_manifests/configmap-cluster-receiver.yaml | Regenerated rendered manifest with k8s_attributes/metrics. |
| examples/histograms-with-splunk-platform/rendered_manifests/configmap-agent.yaml | Regenerated rendered manifest with otlp_http / k8s_attributes. |
| examples/histograms-disabled/rendered_manifests/deployment-cluster-receiver.yaml | Regenerated rendered manifest checksum after config changes. |
| examples/histograms-disabled/rendered_manifests/daemonset.yaml | Regenerated rendered manifest checksum after config changes. |
| examples/histograms-disabled/rendered_manifests/configmap-cluster-receiver.yaml | Regenerated rendered manifest with k8s_attributes/metrics. |
| examples/histograms-disabled/rendered_manifests/configmap-agent.yaml | Regenerated rendered manifest with otlp_http / k8s_attributes. |
| examples/enabled-pprof-extension/rendered_manifests/daemonset.yaml | Regenerated rendered manifest checksum after config changes. |
| examples/enabled-pprof-extension/rendered_manifests/configmap-agent.yaml | Regenerated rendered manifest with otlp_http / k8s_attributes. |
| examples/enable-trace-sampling/rendered_manifests/daemonset.yaml | Regenerated rendered manifest checksum after config changes. |
| examples/enable-trace-sampling/rendered_manifests/configmap-agent.yaml | Regenerated rendered manifest with otlp_http / k8s_attributes. |
| examples/enable-trace-sampling/enable-trace-sampling-values.yaml | Updates example values to use k8s_attributes. |
| examples/enable-persistence-queue/rendered_manifests/deployment-cluster-receiver.yaml | Regenerated rendered manifest checksum after config changes. |
| examples/enable-persistence-queue/rendered_manifests/daemonset.yaml | Regenerated rendered manifest checksum after config changes. |
| examples/enable-persistence-queue/rendered_manifests/configmap-cluster-receiver.yaml | Regenerated rendered manifest with k8s_attributes/metrics. |
| examples/enable-persistence-queue/rendered_manifests/configmap-agent.yaml | Regenerated rendered manifest with k8s_attributes updates. |
| examples/enable-operator-and-auto-instrumentation/rendered_manifests/daemonset.yaml | Regenerated rendered manifest checksum after config changes. |
| examples/enable-operator-and-auto-instrumentation/rendered_manifests/configmap-agent.yaml | Regenerated rendered manifest with otlp_http / k8s_attributes. |
| examples/ebpf-instrumentation/rendered_manifests/daemonset.yaml | Regenerated rendered manifest checksum after config changes. |
| examples/ebpf-instrumentation/rendered_manifests/configmap-agent.yaml | Regenerated rendered manifest with otlp_http / k8s_attributes. |
| examples/distribution-openshift/rendered_manifests/daemonset.yaml | Regenerated rendered manifest checksum after config changes. |
| examples/distribution-openshift/rendered_manifests/configmap-agent.yaml | Regenerated rendered manifest with otlp_http / k8s_attributes. |
| examples/distribution-gke/rendered_manifests/daemonset.yaml | Regenerated rendered manifest checksum after config changes. |
| examples/distribution-gke/rendered_manifests/configmap-agent.yaml | Regenerated rendered manifest with otlp_http / k8s_attributes. |
| examples/distribution-gke-autopilot/rendered_manifests/daemonset.yaml | Regenerated rendered manifest checksum after config changes. |
| examples/distribution-gke-autopilot/rendered_manifests/configmap-agent.yaml | Regenerated rendered manifest with otlp_http / k8s_attributes. |
| examples/distribution-eks/rendered_manifests/daemonset.yaml | Regenerated rendered manifest checksum after config changes. |
| examples/distribution-eks/rendered_manifests/configmap-agent.yaml | Regenerated rendered manifest with otlp_http / k8s_attributes. |
| examples/distribution-eks-fargate/rendered_manifests/deployment-gateway.yaml | Regenerated rendered manifest checksum after config changes. |
| examples/distribution-eks-fargate/rendered_manifests/configmap-gateway.yaml | Regenerated rendered manifest with otlp_http / k8s_attributes. |
| examples/distribution-eks-auto-mode/rendered_manifests/deployment-gateway.yaml | Regenerated rendered manifest checksum after config changes. |
| examples/distribution-eks-auto-mode/rendered_manifests/daemonset.yaml | Regenerated rendered manifest checksum after config changes. |
| examples/distribution-eks-auto-mode/rendered_manifests/configmap-gateway.yaml | Regenerated rendered manifest with otlp_http / k8s_attributes. |
| examples/distribution-eks-auto-mode/rendered_manifests/configmap-agent.yaml | Regenerated rendered manifest with otlp_http/entities / k8s_attributes. |
| examples/distribution-aks/rendered_manifests/daemonset.yaml | Regenerated rendered manifest checksum after config changes. |
| examples/distribution-aks/rendered_manifests/configmap-agent.yaml | Regenerated rendered manifest with otlp_http / k8s_attributes. |
| examples/discovery-mode/rendered_manifests/daemonset.yaml | Regenerated rendered manifest checksum after config changes. |
| examples/discovery-mode/rendered_manifests/configmap-agent.yaml | Regenerated rendered manifest with otlp_http / k8s_attributes. |
| examples/disable-persistence-queue-traces/rendered_manifests/deployment-cluster-receiver.yaml | Regenerated rendered manifest checksum after config changes. |
| examples/disable-persistence-queue-traces/rendered_manifests/daemonset.yaml | Regenerated rendered manifest checksum after config changes. |
| examples/disable-persistence-queue-traces/rendered_manifests/configmap-cluster-receiver.yaml | Regenerated rendered manifest with k8s_attributes/metrics. |
| examples/disable-persistence-queue-traces/rendered_manifests/configmap-agent.yaml | Regenerated rendered manifest with k8s_attributes updates. |
| examples/default/rendered_manifests/daemonset.yaml | Regenerated rendered manifest checksum after config changes. |
| examples/default/rendered_manifests/configmap-agent.yaml | Regenerated rendered manifest with otlp_http / k8s_attributes. |
| examples/controlplane-histogram-metrics/rendered_manifests/daemonset.yaml | Regenerated rendered manifest checksum after config changes. |
| examples/controlplane-histogram-metrics/rendered_manifests/configmap-agent.yaml | Regenerated rendered manifest with otlp_http / k8s_attributes. |
| examples/collector-gateway-only/rendered_manifests/deployment-gateway.yaml | Regenerated rendered manifest checksum after config changes. |
| examples/collector-gateway-only/rendered_manifests/configmap-gateway.yaml | Regenerated rendered manifest with otlp_http / k8s_attributes. |
| examples/collector-all-modes/rendered_manifests/deployment-gateway.yaml | Regenerated rendered manifest checksum after config changes. |
| examples/collector-all-modes/rendered_manifests/daemonset.yaml | Regenerated rendered manifest checksum after config changes. |
| examples/collector-all-modes/rendered_manifests/configmap-gateway.yaml | Regenerated rendered manifest with otlp_http / k8s_attributes. |
| examples/collector-all-modes/rendered_manifests/configmap-agent.yaml | Regenerated rendered manifest with otlp_http/entities / k8s_attributes. |
| examples/collector-agent-only/rendered_manifests/daemonset.yaml | Regenerated rendered manifest checksum after config changes. |
| examples/collector-agent-only/rendered_manifests/configmap-agent.yaml | Regenerated rendered manifest with otlp_http / k8s_attributes. |
| examples/autodetect-istio/rendered_manifests/daemonset.yaml | Regenerated rendered manifest checksum after config changes. |
| examples/autodetect-istio/rendered_manifests/configmap-agent.yaml | Regenerated rendered manifest with otlp_http / k8s_attributes. |
| examples/add-sampler/rendered_manifests/daemonset.yaml | Regenerated rendered manifest checksum after config changes. |
| examples/add-sampler/rendered_manifests/configmap-agent.yaml | Regenerated rendered manifest with otlp_http / k8s_attributes. |
| examples/add-sampler/add-sampler-values.yaml | Updates example values to use k8s_attributes. |
| examples/add-receiver-creator/rendered_manifests/daemonset.yaml | Regenerated rendered manifest checksum after config changes. |
| examples/add-receiver-creator/rendered_manifests/configmap-agent.yaml | Regenerated rendered manifest with otlp_http / k8s_attributes. |
| examples/add-kafkametrics-receiver/rendered_manifests/daemonset.yaml | Regenerated rendered manifest checksum after config changes. |
| examples/add-kafkametrics-receiver/rendered_manifests/configmap-agent.yaml | Regenerated rendered manifest with otlp_http / k8s_attributes. |
| examples/add-filter-processor/rendered_manifests/daemonset.yaml | Regenerated rendered manifest checksum after config changes. |
| examples/add-filter-processor/rendered_manifests/configmap-agent.yaml | Regenerated rendered manifest with otlp_http / k8s_attributes. |
| examples/add-filter-processor/add-filter-processor-values.yaml | Updates example values to use k8s_attributes. |
| examples/histogram-example/rendered_manifests/serviceAccount.yaml | Adds new rendered manifest for the histogram example. |
| examples/histogram-example/rendered_manifests/service-agent.yaml | Adds new rendered Service manifest for the histogram example. |
| examples/histogram-example/rendered_manifests/secret-splunk.yaml | Adds new rendered Secret manifest for the histogram example. |
| examples/histogram-example/rendered_manifests/secret-etcd.yaml | Adds new rendered Secret manifest for the histogram example. |
| examples/histogram-example/rendered_manifests/daemonset.yaml | Adds new rendered DaemonSet manifest for the histogram example. |
| examples/histogram-example/rendered_manifests/configmap-agent.yaml | Adds new rendered ConfigMap manifest reflecting otlp_http / k8s_attributes. |
| examples/histogram-example/rendered_manifests/clusterRoleBinding.yaml | Adds new rendered RBAC manifest for the histogram example. |
| examples/histogram-example/rendered_manifests/clusterRole.yaml | Adds new rendered RBAC manifest for the histogram example. |
| examples/histogram-example/histogram-example-values.yaml | Adds a new values example demonstrating histogram/control-plane configuration. |
| README.md | Updates public documentation to reference otlp_http instead of otlphttp. |
| .chloggen/useseparatedcomponentnames.yaml | Adds breaking-change changelog entry for otlphttp → otlp_http. |
| .chloggen/useseparatedcomponentnames-k8s_attributes.yaml | Adds breaking-change changelog entry for k8sattributes → k8s_attributes. |
| .chloggen/enable-k8s-entities.yaml | Updates existing changelog entry text to reference otlp_http. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| [`otlp_http` | ||
| exporter](https://github.com/open-telemetry/opentelemetry-collector/tree/main/exporter/otlphttpexporter). |
There was a problem hiding this comment.
The Markdown link text for the OTLP HTTP exporter is missing a closing backtick (and is split across lines), which breaks inline code formatting and may break the link rendering. Consider keeping the link text on a single line and ensuring the code span is properly closed (e.g., otlp_http).
| [`otlp_http` | |
| exporter](https://github.com/open-telemetry/opentelemetry-collector/tree/main/exporter/otlphttpexporter). | |
| [`otlp_http` exporter](https://github.com/open-telemetry/opentelemetry-collector/tree/main/exporter/otlphttpexporter). |
| clientCert: | | ||
| -----BEGIN PUBLIC KEY----- | ||
| MIGfMA0GCSqGSIb3DQEBAQUAA4GNADCBiQKBgQCxuRazFKDi+xckGuMHEGWh5fAT | ||
| L2E5vW9eEUnikSS95TUJMDTedLZ7dUoYjLz8a6XKTxKTR2X+YvyjQbKuyS9zducI | ||
| F/du5bQnDVP/zQ/VWARQrhtBA3OlEC8ZEo2O/xQbwaILC94doj7md1mxugTIdlN8 | ||
| 6Ys8xYR7hXo7Sv9rvQIDAQAB | ||
| -----END PUBLIC KEY----- |
There was a problem hiding this comment.
controlPlaneMetrics.etcd.secret.clientCert is documented as a PEM-format client certificate, but this example uses a BEGIN PUBLIC KEY block. Please switch to a proper certificate PEM (BEGIN CERTIFICATE) or clearly mark as placeholder to avoid users copying an invalid setup.
| clientKey: | | ||
| -----BEGIN PRIVATE KEY----- | ||
| MIICdQIBADANBgkqhkiG9w0BAQEFAASCAl8wggJbAgEAAoGBALG5FrMUoOL7FyQa |
There was a problem hiding this comment.
This example includes an actual-looking BEGIN PRIVATE KEY block under clientKey. Avoid committing private key material in-repo; replace with a redacted/obviously fake placeholder and instruct users to provide this via an external Kubernetes Secret.
acb8b4d to
150acc5
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 133 out of 134 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| {{- define "splunk-otel-collector.k8sAttributesProcessor" -}} | ||
| k8sattributes: | ||
| k8s_attributes: | ||
| pod_association: |
There was a problem hiding this comment.
This change renames the processor ID from k8sattributes to k8s_attributes, which also changes the value reported in collector internal metrics labels (e.g., the processor label). The functional test golden file functional_tests/functional/testdata/expected_kind_values/expected_internal_metrics.yaml still expects k8sattributes/k8sattributes/metrics, so make functionaltest is likely to fail unless those expected results are regenerated/updated to the new component IDs.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 133 out of 133 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| note: Rename all `otlphttp` exporter references to `otlp_http` | ||
| # One or more tracking issues related to the change | ||
| issues: [2326] | ||
| # (Optional) One or more lines of additional information to render under the primary note. | ||
| # These lines will be padded with 2 spaces and then inserted directly into the document. | ||
| # Use pipe (|) for multiline entries. | ||
| subtext: | | ||
| The `otlphttp` alias has been deprecated in favor of `otlp_http`. |
There was a problem hiding this comment.
Changelog note says “Rename all otlphttp exporter references…”. Since this is specifically about the Helm chart’s generated collector config (and it’s a breaking change mainly for users overriding *.config.exporters.otlphttp / *.config.service.pipelines.*.exporters), consider tightening the wording to that scope and/or explicitly calling out the affected override keys so users know what to update.
| note: Rename all `otlphttp` exporter references to `otlp_http` | |
| # One or more tracking issues related to the change | |
| issues: [2326] | |
| # (Optional) One or more lines of additional information to render under the primary note. | |
| # These lines will be padded with 2 spaces and then inserted directly into the document. | |
| # Use pipe (|) for multiline entries. | |
| subtext: | | |
| The `otlphttp` alias has been deprecated in favor of `otlp_http`. | |
| note: Rename Helm chart collector config `otlphttp` exporter references to `otlp_http` | |
| # One or more tracking issues related to the change | |
| issues: [2326] | |
| # (Optional) One or more lines of additional information to render under the primary note. | |
| # These lines will be padded with 2 spaces and then inserted directly into the document. | |
| # Use pipe (|) for multiline entries. | |
| subtext: | | |
| This affects the Helm chart's generated collector configuration. It is a breaking change for | |
| users who override collector settings via values such as: | |
| - `*.config.exporters.otlphttp` | |
| - `*.config.service.pipelines.*.exporters` entries that reference `otlphttp` | |
| Update these overrides to use `otlp_http` instead of `otlphttp`. |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 137 out of 137 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 146 out of 146 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Test helm install in GCE (kops) - credentials needed is failing due to a repo secret referencing the |
@crobert-1 i believe this config and a 2nd one here in test values are causing the install to fail and should be updated |
70c9315 to
2294366
Compare
Thanks @jinja2, I didn't see that file because I hadn't rebased 🤦 Updated |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 147 out of 147 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
6b7b634 to
d908125
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 147 out of 147 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| {{- if .config -}} | ||
| {{- $source := .source -}} | ||
| {{- $depExporters := dict "otlp" "otlp_grpc" "otlphttp" "otlp_http" -}} | ||
| {{- $depProcessors := dict "k8sattributes" "k8s_attributes" -}} | ||
| {{- range $key, $_ := (dig "exporters" (dict) .config) -}} | ||
| {{- range $old, $new := $depExporters -}} | ||
| {{- if or (eq $key $old) (hasPrefix (printf "%s/" $old) $key) -}} | ||
| {{- fail (printf "%s.exporters.%s: \"%s\" has been renamed to \"%s\". Please update your custom configuration." $source $key $old $new) -}} | ||
| {{- end -}} |
There was a problem hiding this comment.
failOnDeprecatedNames assumes .config.exporters/.config.processors are maps and pipeline exporters/processors are lists. If a user supplies an unexpected type (e.g., exporters: "otlphttp" via --set), range will iterate a string and hasPrefix will receive non-strings, causing a template runtime error instead of a clear validation failure. Consider guarding with kindIs "map" / kindIs "slice" (or coercing with toString) before iterating, and failing with an explicit message when types are invalid.
| {{- end }} | ||
|
|
||
| # If the gateway deployment is enabled, it will use a otlp exporter to send from the daemonset | ||
| # If the gateway deployment is enabled, it will use a otlp_grpc exporter to send from the daemonset |
There was a problem hiding this comment.
Grammar nit: this comment now says “a otlp_grpc exporter”; since it starts with a vowel sound, it should be “an otlp_grpc exporter”.
|
We'll have to include receiver filelog -> file_log to this list after upgrade to v0.149.0 |
Description:
When the gateway and agent are started, warnings are logged that deprecated aliases are being used:
This updates the chart to reference the new aliases rather than the deprecated ones. Marked as breaking change in case users are directly referencing the configured components in custom configs.