fix: Send remaining queue items if there are more than chunkSize #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TysonAndre
force-pushed
the
send-remaining-queue-items
branch
2 times, most recently
from
5bff5bf to
1a1f2ec
Compare
When the datapointsLength in a call to send() exceeded the chunkSize, the excess items would remain in the queue until there was another call with fewer than chunkSize datapoints. If there were no future calls to send(), the items would remain in the queue. For now, only do this when the previous data is successfully sent to signalfx Fixes signalfx#105
TysonAndre
force-pushed
the
send-remaining-queue-items
branch
from
1a1f2ec to
909d6fa
Compare
seemk
approved these changes
Oct 6, 2023
|
Thanks! I'll do a new release on Monday, most likely 8.0.0 without the beta label |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the datapointsLength in a call to send() exceeded the chunkSize, the excess items would remain in the queue until there was another call with fewer than chunkSize datapoints.
If there were no future calls to send(), the items would remain in the queue.
For now, only do this when the previous data is successfully sent to signalfx
Fixes #105