Align OpAMP data model guidance with upstream#387
Open
breedx-splk wants to merge 1 commit intosignalfx:mainfrom
Open
Align OpAMP data model guidance with upstream#387breedx-splk wants to merge 1 commit intosignalfx:mainfrom
breedx-splk wants to merge 1 commit intosignalfx:mainfrom
Conversation
Kielek
approved these changes
Apr 24, 2026
| Guidance for OpenTelemetry language agents is defined upstream in | ||
| [OpenTelemetry Guidelines](https://github.com/open-telemetry/opamp-spec/blob/main/opentelemetry-guidelines.md) | ||
| in the [opamp-spec](https://github.com/open-telemetry/opamp-spec). | ||
| GDI language agents that use OpAMP SHOULD follow that upstream guidance. |
Contributor
There was a problem hiding this comment.
Can we just remove everything below this line?
It is just duplication. Not a hard blocker from my perspective.
Contributor
Author
There was a problem hiding this comment.
I mean, that would be fine...there are pros/cons.
Pros: shorter doc, more concise.
Cons: this doc is likely to grow beyond identity and will probably contain guidance about configuration etc. Having identify called out might be nice because it's not assumed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This aligns this repo with open-telemetry/opamp-spec#312 and removes the contradictory guidance added in #379.