otel_log_level (common debug) proposal #139
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -135,7 +135,11 @@ beyond the OpenTelemetry specification exist. | |
| - `OTEL_TRACES_EXPORTER` | ||
| - Non-RUM distribution MUST default to `otlp` over gRPC with an endpoint of `localhost:4317` | ||
| - Non-RUM distribution MUST offer `jaeger-thrift-splunk` that defaults to `http://127.0.0.1:9080/v1/trace` | ||
| - `OTEL_LOG_LEVEL` | ||
| - Distribution SHOULD support `DEBUG` setting. With this value all relevant troubleshooting data should be logged. | ||
| - Distribution MAY support additional levels: | ||
| - `INFO` - coarser-grained informational events than the `DEBUG`. | ||
| - `TRACE` - finer-grained informational events than the `DEBUG`. | ||
|
Comment on lines
+140
to
+142
There was a problem hiding this comment. If we're going to use There was a problem hiding this comment. Good point. Let's wait for open-telemetry/opentelemetry-specification#2039 There was a problem hiding this comment. I don't want to introduce log levels here that'll end up not being included in the otel spec... |
||
| #### Real User Monitoring Libraries | ||
|
|
||
| Real User Monitoring (RUM) instrumentation libraries cannot use environment variables for configuration. | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AFAIK supporting this would involve hacking in most of the SDKs. I would rather make a hack to convert
debugtoDEBUGif a component needs it as it seems more OTel compliant.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
open-telemetry/opentelemetry-specification#920
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, we need to wait for the values to be finalized in the spec. Then it will be a no-brainer ;)