demonstrate using subtle-ng-derive with ConstantTimeCmp#478
Closed
cosmicexplorer wants to merge 1 commit intosignalapp:mainfrom
Closed
demonstrate using subtle-ng-derive with ConstantTimeCmp#478cosmicexplorer wants to merge 1 commit intosignalapp:mainfrom
cosmicexplorer wants to merge 1 commit intosignalapp:mainfrom
Conversation
617d227 to
8392b78
Compare
8392b78 to
8d419fe
Compare
Contributor
|
I'm going to close this because it's an extra dependency for something quite subtle (🥁), but it's certainly clever! |
Contributor
Author
|
Note: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
In #469 we decided to take a look at whether we could upstream some extensions to the
subtlecrate to supportOrderingcomparisons. After creating zkcrypto/subtle-ng#5, I created this PR to demonstrate how adoptingsubtle::ConstantTimeCmpfrom that change could improve the code.Solution
subtle-ng-derivecrate in order to derive constant-time comparisons for aggregate structs using the technique developed in reduce boilerplate implementing comparisons for user-defined types zkcrypto/subtle-ng#6.subtle-ngwhich contained the changes from define and implementConstantTime{Partial,}Ordtraits zkcrypto/subtle-ng#5.Result
It is now possible to
#[derive(ConstEq, ConstOrd, ConstantTimeEq, ConstantTimeCmp)]to get constant-timeEqandOrdimplementations for several structs, which allows us to removeutils.rs.