Android: force-link libdl #274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For some reason, the Docker build of libsignal_jni.so doesn't link to libdl, even though the build on my local machine does. This doesn't seem to be a problem on most phones, presumably because the libdl functions are re-exported through libc. However, on a small subset of Android phones this is not good enough and libsignal_jni.so fails to load. For now, work around this by forcing the Android cross-compilation linker to link to libdl (instead of doing it "as needed").
jim-signal
approved these changes
Apr 20, 2021
jrose-signal
added a commit
that referenced
this pull request
Apr 20, 2021
Android: force-link libdl
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason, the Docker build of libsignal_jni.so doesn't link to libdl, even though the build on my local machine does. This doesn't seem to be a problem on most phones, presumably because the libdl functions are re-exported through libc. However, on a small subset of Android phones this is not good enough and libsignal_jni.so fails to load. For now, work around this by forcing the Android cross-compilation linker to link to libdl (instead of doing it "as needed").
Docs for
cargo:rustc-cdylib-link-arg