support for armv7-unknown-linux-gnueabihf #15
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a Tier 3 target, but apart from working around a hardcoded version in the 'cc' crate everything does work.
Cross-compiling to AArch64 Linux can be done with a CMake toolchain file, along with setting the correct compiler and include paths in the environment. Cross-compiling from X64 Windows to ARM64 Windows doesn't look at the toolchain at all, because CMake + Visual Studio can already cross-compile. Unfortunately, the Visual Studio CMake generator doesn't set CMAKE_SYSTEM_PROCESSOR, which is what the BoringSSL CMakeLists.txt is looking at to choose the architecture. For now, disable the use of assembly when cross-compiling on Windows (assuming that the Visual Studio generator will be used there).
Adds CRL types and the ability to verify certificates against CRLs with an X509StoreContext
This corresponds to `X509_get0_extensions`.
BoringSSL vends two libraries: libcrypto and libssl. Some clients don't need the libssl part. With a feature flag, we can skip building it (saving on compile time) and initializing it (saving on code size and a tiny bit of run time). The new feature is on by default for backwards compatibility.
This fixes actual cross-compile cases, like compiling for Apple Silicon on an Intel Mac. It also makes builds more consistent by using the SDK in the installed Xcode instead of the host root headers, which is how Apple recommends people build anyway. (If you only have the command line tools installed, though, it should fall back to those without a problem.)
Signed-off-by: morph027 <[email protected]>
jrose-signal
reviewed
Nov 8, 2022
jrose-signal
left a comment
jrose-signal
left a comment
There was a problem hiding this comment.
Looks good, just one minor comment
|
Also, do you have any objections to us contributing this upstream as well? They took cloudflare#78, and this is pretty much an extension of that. |
Author
Sure, upstream contributions are always good. |
Signed-off-by: morph027 <[email protected]>
|
Guess we need to pull in upstream first… |
jrose-signal
force-pushed
the
libsignal
branch
from
b95cb54 to
78c0858
Compare
|
Rebased the libsignal branch (rebase rather than merge because it helps us keep track of what hasn't been upstreamed), then squashed and merged this in #16. Thank you for this improvement! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for armv7-unknown-linux-gnueabihf
refs signalapp/libsignal#481