Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Screen record for view one time media #5879

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

darkCavalier11
Copy link

@darkCavalier11 darkCavalier11 commented Sep 25, 2024

First time contributor checklist

Contributor checklist

  • My commits are rebased on the latest main branch
  • My commits are in nice logical chunks
  • My contribution is fully baked and is ready to be merged as is
  • I have tested my contribution on these devices:
  • iPhone 16 Sim, iOS 18.0
  • iPhone 13, iOS 18.0
Simulator.Screen.Recording.-.iPhone.16.-.2024-09-25.at.23.06.44.mp4

PS: I needed help for these two blockers. If anybody can comment anything that'd be great.

  • I haven't marked my PR fully baked cause there is a piece of text translation needed, that i couldn't find any proper way Signal adds a localizable string to strings file in documentation.
  • On dark mode, the text part of Signal logo is not visible, cause the text itself is in dark color, I found a white signal logo from official site, but not sure if Signal uses any kind of pre-processing before adding images cause most image files are in pdf format. Here added a ss for the reference
    Simulator Screenshot - iPhone 16 - 2024-09-25 at 23 07 24

Description

Fixing #5843
When view loaded now the check is done if the screen is being recorded. If thats the case a restrictScreenCapturePlaceholderView shown on top of once media to block user from seeing the content. A notification observation when UI screen capture value change setup is done to perform the same thing.
Before, if the view once content is a video it automatically played when user opens the media and video still plays when user dismisses the once media view. Fixed that here by playing the video based on the UI screen capture status of the app and stop the video player when view dismissed.

@parenthetical-e
Copy link

I was hoping for a status check on getting this merged. :)

@w1redch4d
Copy link

seems very pathetic: signalapp/Signal-Android#12350 (i wonder if i send a PR will it get merged :/ )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants