fix for window not being shown with wayland in same cases by switching to the 'did-finish-load' event instead of 'ready-to-show' #7078
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to the 'did-finish-load' event instead of 'ready-to-show' related issues: signalapp#6368 signalapp#6740 signalapp#6966 electron/electron#25253 (comment) After a deep rabbit hole into electron and the chromium source code I could not determine why this event is not fired, but both events should be more or less equal from their timing in our case: https://www.electronjs.org/docs/latest/api/browser-window > ### Using the `ready-to-show` event > This event is usually emitted after the did-finish-load event, but for pages with many remote resources, it may be emitted before the did-finish-load event.
|
would love to see this merged, currently can't launch the app without xwayland where it's pixelated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First time contributor checklist:
Contributor checklist:
mainbranchnpm run readyrun passes successfully (more about tests here)related issues:
Description
on some setups signal is never shown due to electrons
ready-to-showevent is not firing.I've found that people use
did-finish-loadinstead due to (probably) this bug (electron/electron#25253 (comment)).After a deep rabbit hole into electron and the chromium source code I could not determine why this event is not fired, but both events should be more or less equal from their timing in our case, so it is a workaround, but can be used permanently.
https://www.electronjs.org/docs/latest/api/browser-window
setup with which I could reproduce the issue and verify the fix
main(git checkout v7.35.0-alpha.1)ELECTRON_OZONE_PLATFORM_HINT=autoenvironment variable