-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change the highest priority Persian font to Vazirmatn #6688
Conversation
Thanks @MahdiNazemi, this already looks a lot better. |
You're welcome. I'm glad you like how the app looks with Vazirmatin. I know you have been asking for a better font for over five years! |
@MahdiNazemi Just one last point, would this change the font across the board, or just when using the |
I concur with your viewpoint, and I also wish for an aesthetically pleasing font irrespective of the locale or language settings. However, I believe that given the availability of the new language setting, switching the language to Persian as a means to obtain such a font is a reasonable compromise until more optimal solutions can be implemented. There is a way to deal with multilingual text as described here (quote from the MDN Web Docs):
My knowledge in this area is very limited, but I imagine for Signal to display Persian texts well, a font like Vazirmatn should be bundled with the app and added to This may introduce other issues because Persian and Arabic have some common letters (same unicode representation), but people reading Persian will probably find a font easy on the eyes that those who read in Arabic don't. In this case, I suspect applying the correct font family to a text message necessitates the detection of the language used in the text. This detection process may involve employing a simple n-gram model or a more advanced neural network-based model to distinguish between languages such as Persian and Arabic, ensuring the appropriate font family is applied for each language. Alternatively, the app may be able to get a user's preferred languages or the active keyboard's language from the OS to guide the typeface selection. These are probably very well-known problems with well-known solutions. Getting an expert's opinion on the issue will probably save us a lot of time. |
We've done a little research ourselves, and we're feeling good about this change. I've merged it, and it will be in our next beta release. Thanks for all your effort on this! |
Thank you for considering the PR and integrating it into the next beta release. |
Hello, There is a simple feature request for Desktop app with good Urdu fonts support. On the Desktop app the font for Urdu language is not good enough. Choosing a better font at least will be a great feature. It's very much related to PR but with Urdu fonts instead of Persian fonts signalapp#6688
Description
With the introduction of the language setting in version 6.39.0, this may be a good time to update the default font for Persian to Vazirmatn, which can greatly enhance readability and aesthetics. It is worth noting that Vazirmatn font is highly sought after by the Signal community, as can be observed in the following sources:
While personal preferences regarding font readability and aesthetics may vary, I believe that Vazirmatn font will cater to the needs of the majority of Signal users who read and write in Persian.
The code has been tested on macOS Sonoma 14.1.1.
![Screenshot 2023-11-25 at 2 42 27 PM](https://private-user-images.githubusercontent.com/11276349/285619164-14a350a2-4348-40aa-a427-e7a72d485563.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjQ3MzcwMDcsIm5iZiI6MTcyNDczNjcwNywicGF0aCI6Ii8xMTI3NjM0OS8yODU2MTkxNjQtMTRhMzUwYTItNDM0OC00MGFhLWE0MjctZTdhNzJkNDg1NTYzLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA4MjclMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwODI3VDA1MzE0N1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTQyOTJhODkyY2M3N2RiODgyYjU1ZmI5NTdlOWEwNTE2YzZkMjVlZDEwYTAwMDYwYjFkMDk0NDVjMzY5MWUzM2MmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.bs009WP4DuL_9FwbTfiu01WRVHLzfqByp9xGwCcOMU0)
First time contributor checklist:
Contributor checklist:
main
branchyarn ready
run passes successfully (more about tests here)