Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firefox Support #574

Closed
wants to merge 9 commits into from
Closed

Firefox Support #574

wants to merge 9 commits into from

Conversation

codedust
Copy link
Contributor

@codedust codedust commented Jan 4, 2016

This is a first step towards Firefox (WebApp) support. I didn't change the behavior of the Chrome extension, so it's still perfectly usable in Chrome.

Of course, this still needs some testing. Feel free to try it out and let me know of your experiences!

To register without installing Signal as a Firefox WebApp, we need an HTTP server (for ajax requests to work):

python3 -m http.server 8000

Next, open http://localhost:8000/index_mozilla.html and follow the instructions. Alternatively, you can also do a standalone registration.
It's always a good idea to have a look at the developer console (F12).

@janimo
Copy link

janimo commented Jan 9, 2016

I am not affiliated with OWS but my opinion is that the chances of some of this going in would be much better if it were separated in many smaller pull requests, the most obvious ones being fixing the chromium checks in .js . Then the additional mozilla specific new files could be a single merged commit which would be easier to apply to a moving master branch.

codedust added a commit to codedust/Textsecure-Browser that referenced this pull request Jan 10, 2016
This is a first step towards Firefox WebApp compatibility.

See signalapp#574
@codedust
Copy link
Contributor Author

@janimo You are right. I'll split this pr up into several smaller commits and close it afterwards.

codedust added a commit to codedust/Textsecure-Browser that referenced this pull request Jan 10, 2016
codedust added a commit to codedust/Textsecure-Browser that referenced this pull request Jan 10, 2016
This will make it possible to run Signal as a Firefox WebApp.

(see signalapp#574)
@codedust
Copy link
Contributor Author

This pull request is now split up into the pull requests #592, #593, #594, #595 and #596.

@codedust codedust closed this Jan 10, 2016
@gerdneuman
Copy link

@codedust Would be great if there was some info on https://github.com/WhisperSystems/Signal-Desktop/blob/master/CONTRIBUTING.md on how to start Contributing for Firefox 😃 Really looking forward to this!

@codedust
Copy link
Contributor Author

@gerdneuman 👍 At the moment I'm waiting for feedback by @liliakai. Adding some info to the contributing file would be a good idea after the initial pull requests get merged.

@r-a-y
Copy link

r-a-y commented Aug 20, 2016

Firefox Apps no longer work as of Firefox 48:
https://support.mozilla.org/en-US/kb/runtime

Given that Chrome Apps are also being phased out (#871), it might make sense to port the Chrome App to a Chrome extension and then use Firefox's WebExtension API to port to Firefox.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants