Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove BaseUnitTest.java #13804

Conversation

jamesonwilliams
Copy link
Contributor

@jamesonwilliams jamesonwilliams commented Nov 20, 2024

Contributor checklist

  • Local host (JVM tests)
  • My contribution is fully baked and ready to be merged as is
  • I ensure that all the open issues my contribution fixes are mentioned in the commit message of my first commit using the Fixes #1234 syntax

Description

I noticed that a few of the tests had a BaseUnitTest - however, it was entirely unused! So, I removed it and validated that all the tests still passed (they did).

While I was touching these files, I added a variety of other small improvements:

  • Import org.junit instead of junt.framework
  • Always use expected value as the first argument to assertEqual(expected: Object, actual: Object) - these were frequently backwards in the touched files. (I used a regex to swap these.)
  • Removed not-thrown Exception on test function signatures
  • For VerificationCodeParserTest.java, use a parameterized JUnit test

Testing

./gradlew qa 
[...snip...]
BUILD SUCCESSFUL in 5m 4s

@jamesonwilliams jamesonwilliams marked this pull request as ready for review November 20, 2024 06:39
@greyson-signal
Copy link
Contributor

Awesome, thanks for the cleanup!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants