Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update lintchecks module: migrate to KTS and fix tests #13759

Closed
wants to merge 3 commits into from

Conversation

valldrac
Copy link
Contributor

Description

While adding some extra lint checks, I noticed that parts of the lintchecks module were a bit outdated. This PR makes a few minor changes, hopefully saving some maintenance time to your team.

Thanks for the continued work on Signal. Happy to contribute!

Summary of changes

  • Migrate build script to Kotlin.
  • Update lint version to 31.4.0 to align with the current AGP version (Google's recommendation found here).
  • Fix broken unit tests in CardViewDetectorTest and LogDetectorTest.

Adding the lintchecks:test gradle task to the qa task could be a good idea too, to keep the tests updated.

@greyson-signal
Copy link
Contributor

Thank you very much! This will go out in 7.24 :)

@valldrac valldrac deleted the lintchecks-kts branch November 6, 2024 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants