add dart implementation #83
Conversation
There was a problem hiding this comment.
This looks good to me, with a couple of comments.
Additionally, I would love it if we could run the tests in CI:
Could you please add a dart.yaml workflow file here that will run the dart tests? Something like:
name: Dart
on:
pull_request:
branches: [main]
push:
branches: [main]
jobs:
build:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: dart-lang/setup-dart@v1
- run: dart pub get
- run: dart format --output=none --set-exit-if-changed .
- run: dart analyze
- run: dart test
```| @@ -0,0 +1,29 @@ | |||
| BSD 3-Clause License | |||
|
|
|||
There was a problem hiding this comment.
are you open to use the main license for this repo?
https://github.com/sign-language-processing/pose/blob/master/LICENSE.txt
There was a problem hiding this comment.
I could replace/remove the license but pub dev needs a open license.
| name: pose | ||
| description: Dart library for loading, viewing, augmenting, and handling .pose files | ||
| version: 1.1.5 | ||
| repository: https://github.com/bipinkrish/pose |
There was a problem hiding this comment.
should we move this away? if you want to keep it under your repository, maybe we should create a git sub-module that just links to your repo?
There was a problem hiding this comment.
That is for pub.dev to link a repository.
There was a problem hiding this comment.
maybe we should create a git sub-module that just links to your repo?
Your call, either is ok for me.
On it. |
* workflow for dart * dart format test fix
|
Added workflow, your call on sub-module |
|
I am sorry I messed it up |
Added dart code, open to comments