-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix/remove components crash (and tests for pose.remove_components()) #150
Bugfix/remove components crash (and tests for pose.remove_components()) #150
Conversation
…pose into sign-language-processing-master
Needs more testing: https://chatgpt.com/share/67a683c5-b510-800e-8973-95dbffcce12d |
Right now, this does not work! For example the following test case fails: def test_pose_remove_legs(mediapipe_poses_test_data: List[Pose]):
points_that_should_be_hidden = ["KNEE", "HEEL", "FOOT", "TOE"]
for pose in mediapipe_poses_test_data:
# pose_hide_legs(pose)
pose = pose_remove_legs(pose)
for component in pose.header.components:
point_names = [point.upper() for point in component.points]
for point_name in point_names:
for point_that_should_be_hidden in points_that_should_be_hidden:
assert point_that_should_be_hidden not in point_name |
There is no such function |
Right, it's in pose_evaluation |
…so header matches body
@AmitMY The fixed remove_components() and accompanying tests are now ready for review. Tested to ensure that it won't crash if you try to remove points from components that don't exist, or if you you remove both a component and a point IN that component, etc. |
Fix #149, crash when removing specific points