Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

typing twice in windows with crossterm-0.26+ #109

Closed
viruscamp opened this issue Mar 2, 2023 · 2 comments · Fixed by #110
Closed

typing twice in windows with crossterm-0.26+ #109

viruscamp opened this issue Mar 2, 2023 · 2 comments · Fixed by #110

Comments

@viruscamp
Copy link
Contributor

crossterm-0.26 introduce a new feature Support key release events for windows which makes irust typing twice in windows.

See
crossterm-rs/crossterm#752
helix-editor/helix#6133

And this is a fix method: helix-editor/helix#6139
@sigmaSd
Copy link
Owner

sigmaSd commented Mar 2, 2023

Hello, thanks for investigating this, do you mind opening a PR, I don't have windows to test

viruscamp added a commit to viruscamp/IRust that referenced this issue Mar 2, 2023
@viruscamp
fix sigmaSd#109 typing twice in windows with crossterm-0.26+
696a8d6
@viruscamp viruscamp mentioned this issue Mar 2, 2023
Merged
@viruscamp
Copy link
Contributor Author

Hello, thanks for investigating this, do you mind opening a PR, I don't have windows to test

OK, PR made.

sigmaSd added a commit that referenced this issue Mar 2, 2023
@sigmaSd
Merge pull request #110 from viruscamp/ignore-key-release
6297477 
fix #109 typing twice in windows with crossterm-0.26+
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix #109 typing twice in windows with crossterm-0.26+ viruscamp/IRust
2 participants
@viruscamp @sigmaSd