Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#117 Warning about MJML missing when using MRML #118

Merged
merged 1 commit into from
Feb 1, 2024
Merged

#117 Warning about MJML missing when using MRML #118

merged 1 commit into from
Feb 1, 2024

Conversation

sighmon
Copy link
Owner

@sighmon sighmon commented Jan 22, 2024 •
edited
Loading

Resolves #117

  • Add a check for a valid MRML binary

Testing

  1. Uninstall/remove mjml from your environment
  2. Clone and switch to using this branch in your Gemfile: gem 'mjml-rails', path: '../mjml-rails/'
  3. Add config.use_mrml = true to your initializer
  4. Add mrml to your Gemfile
  5. Note the warning of a missing MJML binary no longer occurs

@sighmon sighmon mentioned this pull request Jan 22, 2024
Closed
@sighmon sighmon merged commit 3bd8012 into master Feb 1, 2024
32 checks passed
@sighmon sighmon deleted the fix/117-mjml-missing-warning-with-mrml branch February 1, 2024 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Warning about MJML missing when using MRML
1 participant
@sighmon