wasm: Revert incorrect fixes for emsdk+webpack build #1191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
V-FEXrt
changed the title
V-FEXrt
requested review from
richardxia,
ErikParawell-SiFive,
JakeSiFive and
mmjconolly
ErikParawell-SiFive
approved these changes
Apr 1, 2023
JakeSiFive
approved these changes
Apr 3, 2023
richardxia
approved these changes
Apr 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously I set
ENVIRONMENT=webas a "fix" for the wasm+emsdk builds. This resulted in a passing build but broke the desktop version of the extension at runtime. (Unsurprisingly it fixed the web version)This change reverts that and pins back to an older version of emsdk. I think the revert is needed as newer versions of emsdk more readily use ES6 style exports which then in turn breaks webpack. (webpack/webpack#16878). We can possible avoid this by setting
EXPORT_ES6=0and that did seem to work but after spending all day deep in the weeds I just want to return to a known working state so desktop users can continue to be productive.This comes at a cost to the web version of the LSP, for some reason its failing in a new/different way that it has before even though we should be returning to old functionality. In the short term this tradeoff seems reasonable as most users use the desktop app and syntax highlighting, the most important feature for code review, still works with the web extension.
There is some interesting discussion at emscripten-core/emscripten#19066 as well. Hopefully we can get this resolved fairly quickly.
After landing this we should fast track a release since folks have been without a working desktop LSP for a bit.