Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

customized proof-view.css is overwritten by updating the extension #100

Open
siegebell opened this issue Dec 2, 2016 · 3 comments
Open

Comments

@siegebell
Copy link
Owner

Updating vscoq causes user-customizations to proof-view.css to be overwritten.

Possible resolutions:

  1. Store proof-view.css in the workspace-settings folder. This means that it will be specific to one project and would have to manually copied to all other projects. I dislike this approach because most users would expect their color/style changes to be universal.
  2. Store proof-view.css in a per-user settings folder. Ideally, vscode would tell extensions where they can store user settings; but this is not yet implemented ([ExtensionDev] Expose API to get at file system locations microsoft/vscode#2741). I could calculate where vscode puts such settings, but it is very likely to change in the next release or two. Otherwise, I can manually calculate where user settings should go -- this is not trivial because Linux, OS X, and Windows all have different expectations... and this would make adopting vscode's proscribed approach a breaking change when it becomes available.

@jonleivent fyi

siegebell pushed a commit that referenced this issue Dec 5, 2016
@siegebell
Copy link
Owner Author

@jonleivent when 0.2.6 is released, you can set coq.hacks.userSettingsLocation to a directory that won't be overwritten when the extension is updated. proof-view.css will be stored in this directory, if specified.

Note: I will likely remove coq.hacks.userSettingsLocation when vscode eventually gets an equivalent feature.

@jonleivent
Copy link

If I put a proof-view.css file in coq.hacks.userSettingsLocation, is it used instead of the normal proof-view.css, or in addition to it?

@siegebell
Copy link
Owner Author

Instead of (hopefully...)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants