Add support for timezone connection option #996
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for the
timezone
connection option as specified bymysqljs/mysql
:Inspired by #732 but with tests and against current master. Removes the need to run tests with
process.env.TZ = 'UTC'
. It doesn't set the sessiontime_zone
variable, but the user should do that if the server time zone is not the same as the requested time zone. However, sincetime_zone
only applies totimestamp
columns and date functions — and not storeddatetime
values — the client and server really need to agree on the time zone in advance anyway.Fixes #15, #262, #642, #877, #888, and maybe others.