Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add threadId and config getters to PromiseConnection #994

Merged
merged 3 commits into from
Aug 6, 2019

Conversation

trevorr
Copy link
Contributor

@trevorr trevorr commented Aug 6, 2019

These properties are documented in mysqljs/mysql [config] [threadId] and typed in types/mysql2 but not directly exposed in PromiseConnection.

@sidorares
Copy link
Owner

Thanks @trevorr ! can you add simple unit test for this?

@trevorr
Copy link
Contributor Author

trevorr commented Aug 6, 2019

I feared you might ask that, as I'd have to downgrade from MySQL 8 to run the tests. 😉 However, your request is fair, so here you go.

@sidorares
Copy link
Owner

I have previous previous experience of accidentally removing / breaking the code that is not used often and not realising that for many month :)

@sidorares
Copy link
Owner

I'd have to downgrade from MySQL 8 to run the tests.

I use mysql in local docker to test different versions

@sidorares sidorares merged commit 108f178 into sidorares:master Aug 6, 2019
@trevorr trevorr deleted the promise-connection-threadid branch August 9, 2019 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants