Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: circular dependencies #3081

Merged
merged 9 commits into from
Nov 13, 2024

chore: better organize new files

623e8c9
Select commit
Loading
Failed to load commit list.
Merged

fix: circular dependencies #3081

chore: better organize new files
623e8c9
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Nov 12, 2024 in 0s

88.23% (target 88.00%)

View this Pull Request on Codecov

88.23% (target 88.00%)

Details

Codecov Report

Attention: Patch coverage is 81.31313% with 333 lines in your changes missing coverage. Please review.

Project coverage is 88.23%. Comparing base (d94bfaa) to head (623e8c9).
Report is 65 commits behind head on master.

Files with missing lines Patch % Lines
lib/base/connection.js 82.64% 164 Missing ⚠️
lib/promise/connection.js 63.96% 80 Missing ⚠️
lib/base/pool.js 87.55% 29 Missing ⚠️
promise.js 55.35% 25 Missing ⚠️
lib/promise/pool.js 84.82% 17 Missing ⚠️
lib/base/pool_connection.js 84.12% 10 Missing ⚠️
lib/promise/prepared_statement_info.js 78.12% 7 Missing ⚠️
lib/pool_connection.js 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3081      +/-   ##
==========================================
+ Coverage   88.13%   88.23%   +0.10%     
==========================================
  Files          71       83      +12     
  Lines       12890    12983      +93     
  Branches     1355     1370      +15     
==========================================
+ Hits        11361    11456      +95     
+ Misses       1529     1527       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.