Skip to content

The eslint-config-prettier package should be moved to devDependencies #1783

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
joakimbeng opened this issue Jan 12, 2023 · 1 comment
Closed

The eslint-config-prettier package should be moved to devDependencies #1783

joakimbeng opened this issue Jan 12, 2023 · 1 comment

Comments

@joakimbeng
Copy link

Great that some packages have moved to devDependencies in the new v3.0 release but there is one more that should be moved. It's the eslint-config-prettier package.

Currently when installing mysql2 it complains that eslint is missing because it's a peerDependency of eslint-config-prettier.
sidorares added a commit that referenced this issue Jan 13, 2023
@sidorares
Merge pull request #1785 from sidorares/move-eslint-config-prettier-t…
2fcfcf5 
…o-dev

build(deps): move eslint-config-prettier to devDependencies. fixes #1783
This was referenced Jan 13, 2023
Merged
Merged
@sidorares
Copy link
Owner

@joakimbeng https://github.com/sidorares/node-mysql2/releases/tag/v3.0.1

First release pushed automatically to npm by release-please

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sidorares @joakimbeng