Merge pull request #689 from swftvsn/patch-2

Wrap executePacket.toPacket(1) call with try/catch
sidorares · Jan 31, 2018 · b6175d8 · b6175d8
2 parents 1ff8890 + 9d46fbb
commit b6175d8
Showing 1 changed file with 11 additions and 1 deletion.
diff --git a/lib/commands/execute.js b/lib/commands/execute.js
@@ -50,7 +50,17 @@ Execute.prototype.start = function(packet, connection) {
     this.parameters,
     connection.config.charsetNumber
   );
-  connection.writePacket(executePacket.toPacket(1));
+  //For reasons why this try-catch is here, please see 
+  // https://github.com/sidorares/node-mysql2/pull/689 
+  //For additional discussion, see 
+  // 1. https://github.com/sidorares/node-mysql2/issues/493
+  // 2. https://github.com/sidorares/node-mysql2/issues/187
+  // 3. https://github.com/sidorares/node-mysql2/issues/480
+  try {
+    connection.writePacket(executePacket.toPacket(1));
+  } catch (error) {
+    this.onResult(error)
+  }
   return Execute.prototype.resultsetHeader;
 };