fix: The removeIdleTimeoutConnectionsTimer did not clean up when the … (

#2384) * fix: The removeIdleTimeoutConnectionsTimer did not clean up when the pool was closed. * test: when the pool is closed, it should clean up timers.
sidorares · Jan 18, 2024 · 18a44f6 · 18a44f6 · danigomez · Jan 22, 2024
1 parent ba8fafb
commit 18a44f6
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 1 deletion.
diff --git a/lib/pool.js b/lib/pool.js
@@ -100,6 +100,7 @@ class Pool extends EventEmitter {
 
   end(cb) {
     this._closed = true;
+    clearTimeout(this._removeIdleTimeoutConnectionsTimer);
     if (typeof cb !== 'function') {
       cb = function(err) {
         if (err) {

diff --git a/test/integration/test-pool-release-idle-connection.js b/test/integration/test-pool-release-idle-connection.js
@@ -38,7 +38,6 @@ pool.getConnection((err1, connection1) => {
           connection4.release();
           connection4.destroy();
           pool.end();
-          setTimeout(() => process.exit(0), 1000);
         });
       }, 7000);
     });