Skip to content

Use NewRequestWithContext #200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 3, 2022
Merged

Use NewRequestWithContext #200

merged 2 commits into from
Apr 3, 2022

Conversation

moredure
Copy link
Contributor

@moredure moredure commented Apr 2, 2022 •
edited
Loading

It's also has lower allocations since request created with context immediately, instead of recreating request WithContext.

@coveralls
Copy link

coveralls commented Apr 2, 2022 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling d27f212 on moredure:patch-6 into f5dc865 on sideshow:master.

@moredure moredure force-pushed the patch-6 branch 2 times, most recently from 69aa90c to 923458b Compare April 2, 2022 18:52
@sideshow sideshow merged commit 7f86e1c into sideshow:master Apr 3, 2022
@sideshow
Copy link
Owner

sideshow commented Apr 3, 2022

Thanks for the PR!

@moredure moredure deleted the patch-6 branch April 3, 2022 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@moredure @coveralls @sideshow